You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/14 21:09:16 UTC

[GitHub] [airflow] Taragolis commented on a diff in pull request #24448: Convert the batch sample dag to system tests (AIP-47)

Taragolis commented on code in PR #24448:
URL: https://github.com/apache/airflow/pull/24448#discussion_r897324743


##########
airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -126,6 +134,7 @@ def __init__(
         aws_conn_id: Optional[str] = None,
         region_name: Optional[str] = None,
         tags: Optional[dict] = None,
+        wait_for_completion: bool = True,

Review Comment:
   Hi, I know that is just draft PR.
   But would you like also add changes in the extra link conditional property
   
   https://github.com/apache/airflow/blob/7d8a17b2107a962e1ffcdb22fc13e1d23a98fdb7/airflow/providers/amazon/aws/operators/batch.py#L104-L111
   
   If `wait_for_completion` sets to `False` then there is no reason add `BatchJobDefinitionLink()` and  `BatchJobQueueLink()` since it executed at `monitor_job` method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org