You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> on 2011/04/01 18:33:40 UTC
Re: svn commit: r1054087 - in /subversion/trunk: Makefile.in build/ac-macros/swig.m4 build/generator/gen_make.py
2010-12-31 12:01:57 danielsh@apache.org napisał(a):
> Author: danielsh
> Date: Fri Dec 31 11:01:56 2010
> New Revision: 1054087
>
> URL: http://svn.apache.org/viewvc?rev=1054087&view=rev
> Log:
> Don't error on 'none: bad command or file name' when SWIG was disabled
> at configure-time.
>
> (Yes, I'm on Debian, thanks for asking.)
>
> * Makefile.in
> (check-SWIG): New target.
> (swig-py, swig-pl, swig-rb): Use new target to fail early.
>
> * build/generator/gen_make.py
> (Generator.write): Use the new target in build-outputs.mk, too.
>
> * build/ac-macros/swig.m4
> (SVN_FIND_SWIG): Don't check for 'none', just set the thing to 'none'.
> As a side effect, the message to stdout is obliterated.
>
> Modified:
> subversion/trunk/Makefile.in
> subversion/trunk/build/ac-macros/swig.m4
> subversion/trunk/build/generator/gen_make.py
>
> Modified: subversion/trunk/Makefile.in
> URL: http://svn.apache.org/viewvc/subversion/trunk/Makefile.in?rev=1054087&r1=1054086&r2=1054087&view=diff
> ==============================================================================
> --- subversion/trunk/Makefile.in (original)
> +++ subversion/trunk/Makefile.in Fri Dec 31 11:01:56 2010
> @@ -702,6 +702,12 @@ install-man:
> install-swig-py: install-swig-py-lib
> install-swig-rb: install-swig-rb-lib
>
> +check-SWIG:
> + if [ "$(SWIG)" = "none" ]; then \
> + echo "SWIG disabled at configure time" >&2; \
> + exit 1; \
> + fi
> +
Release tarballs contain files pregenerated by SWIG. This revision probably breaks support
for building SWIG-based bindings from release tarballs when SWIG is not available.
--
Arfrever Frehtes Taifersar Arahesis
Re: svn commit: r1054087 - in /subversion/trunk: Makefile.in
build/ac-macros/swig.m4 build/generator/gen_make.py
Posted by Daniel Shahaf <da...@apache.org>.
Arfrever,
Could you test if r1088462 fixes your issue?
The build-outputs.mk macros GEN_SWIG_WRAPPER,CHECKOUT_SWIG,GEN_SWIG_RUNTIME
also use $(SWIG). Even though I haven't touched them, I still trigger the
check-SWIG error immediately when I do './configure --without-swig && make swig-py'.
However, upon code inspection it seems that some of them do attempt to run
$(SWIG), so I'm not sure if they have to be modified too.
Thanks,
Daniel
Arfrever Frehtes Taifersar Arahesis wrote on Mon, Apr 04, 2011 at 00:25:45 +0200:
> 2011-04-02 04:02:03 Daniel Shahaf napisał(a):
> > Arfrever Frehtes Taifersar Arahesis wrote on Fri, Apr 01, 2011 at 18:33:40 +0200:
> > > 2010-12-31 12:01:57 danielsh@apache.org napisał(a):
> > > > Author: danielsh
> > > > Date: Fri Dec 31 11:01:56 2010
> > > > New Revision: 1054087
> > >
> > > Release tarballs contain files pregenerated by SWIG. This revision probably breaks support
> > > for building SWIG-based bindings from release tarballs when SWIG is not available.
> > >
> >
> > Thanks for pointing that out.
> >
> > The problem I attempted to fix was that, in my trunk working copies
> > (which I, most of the time, configure --without-swig), running
> > 'make swig-foo' would attempt to run a command called "none". (This is
> > because configure sets SWIG, which normally points to a 'swig' binary,
> > to 'none'.)
> >
> > I'm sure there is a cleaner solution somewhere, but I don't have any
> > ideas right now. (I could look later for a better place to move this
> > check to, but a quick browse through the Makefile hasn't unearthed it
> > for me.) Do you have any suggestions as to a fix?
>
> check-SWIG target shouldn't be a dependency of swig-pl, swig-py and swig-rb targets.
> check-SWIG target should be a dependency of targets for individual .c files in
> "Section 4: Rules to build SWIG .c files from .i files" in (generated) build-outputs.mk.
>
> --
> Arfrever Frehtes Taifersar Arahesis
Re: svn commit: r1054087 - in /subversion/trunk: Makefile.in
build/ac-macros/swig.m4 build/generator/gen_make.py
Posted by Daniel Shahaf <da...@apache.org>.
Thanks for suggesting a fix. I'll look into it, and for now I've filed
issue #3850 and marked it as a release blocker assigned to myself.
http://subversion.tigris.org/issues/show_bug.cgi?id=3850
Re: svn commit: r1054087 - in /subversion/trunk: Makefile.in build/ac-macros/swig.m4 build/generator/gen_make.py
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2011-04-02 04:02:03 Daniel Shahaf napisał(a):
> Arfrever Frehtes Taifersar Arahesis wrote on Fri, Apr 01, 2011 at 18:33:40 +0200:
> > 2010-12-31 12:01:57 danielsh@apache.org napisał(a):
> > > Author: danielsh
> > > Date: Fri Dec 31 11:01:56 2010
> > > New Revision: 1054087
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1054087&view=rev
> > > Log:
> > > Don't error on 'none: bad command or file name' when SWIG was disabled
> > > at configure-time.
> > >
> > > (Yes, I'm on Debian, thanks for asking.)
> > >
> > > * Makefile.in
> > > (check-SWIG): New target.
> > > (swig-py, swig-pl, swig-rb): Use new target to fail early.
> > >
> > > * build/generator/gen_make.py
> > > (Generator.write): Use the new target in build-outputs.mk, too.
> > >
> > > * build/ac-macros/swig.m4
> > > (SVN_FIND_SWIG): Don't check for 'none', just set the thing to 'none'.
> > > As a side effect, the message to stdout is obliterated.
> > >
> > > Modified:
> > > subversion/trunk/Makefile.in
> > > subversion/trunk/build/ac-macros/swig.m4
> > > subversion/trunk/build/generator/gen_make.py
> > >
> > > Modified: subversion/trunk/Makefile.in
> > > URL: http://svn.apache.org/viewvc/subversion/trunk/Makefile.in?rev=1054087&r1=1054086&r2=1054087&view=diff
> > > ==============================================================================
> > > --- subversion/trunk/Makefile.in (original)
> > > +++ subversion/trunk/Makefile.in Fri Dec 31 11:01:56 2010
> > > @@ -702,6 +702,12 @@ install-man:
> > > install-swig-py: install-swig-py-lib
> > > install-swig-rb: install-swig-rb-lib
> > >
> > > +check-SWIG:
> > > + if [ "$(SWIG)" = "none" ]; then \
> > > + echo "SWIG disabled at configure time" >&2; \
> > > + exit 1; \
> > > + fi
> > > +
> >
> > Release tarballs contain files pregenerated by SWIG. This revision probably breaks support
> > for building SWIG-based bindings from release tarballs when SWIG is not available.
> >
>
> Thanks for pointing that out.
>
> The problem I attempted to fix was that, in my trunk working copies
> (which I, most of the time, configure --without-swig), running
> 'make swig-foo' would attempt to run a command called "none". (This is
> because configure sets SWIG, which normally points to a 'swig' binary,
> to 'none'.)
>
> I'm sure there is a cleaner solution somewhere, but I don't have any
> ideas right now. (I could look later for a better place to move this
> check to, but a quick browse through the Makefile hasn't unearthed it
> for me.) Do you have any suggestions as to a fix?
check-SWIG target shouldn't be a dependency of swig-pl, swig-py and swig-rb targets.
check-SWIG target should be a dependency of targets for individual .c files in
"Section 4: Rules to build SWIG .c files from .i files" in (generated) build-outputs.mk.
--
Arfrever Frehtes Taifersar Arahesis
Re: svn commit: r1054087 - in /subversion/trunk: Makefile.in
build/ac-macros/swig.m4 build/generator/gen_make.py
Posted by Daniel Shahaf <da...@apache.org>.
Arfrever Frehtes Taifersar Arahesis wrote on Fri, Apr 01, 2011 at 18:33:40 +0200:
> 2010-12-31 12:01:57 danielsh@apache.org napisał(a):
> > Author: danielsh
> > Date: Fri Dec 31 11:01:56 2010
> > New Revision: 1054087
> >
> > URL: http://svn.apache.org/viewvc?rev=1054087&view=rev
> > Log:
> > Don't error on 'none: bad command or file name' when SWIG was disabled
> > at configure-time.
> >
> > (Yes, I'm on Debian, thanks for asking.)
> >
> > * Makefile.in
> > (check-SWIG): New target.
> > (swig-py, swig-pl, swig-rb): Use new target to fail early.
> >
> > * build/generator/gen_make.py
> > (Generator.write): Use the new target in build-outputs.mk, too.
> >
> > * build/ac-macros/swig.m4
> > (SVN_FIND_SWIG): Don't check for 'none', just set the thing to 'none'.
> > As a side effect, the message to stdout is obliterated.
> >
> > Modified:
> > subversion/trunk/Makefile.in
> > subversion/trunk/build/ac-macros/swig.m4
> > subversion/trunk/build/generator/gen_make.py
> >
> > Modified: subversion/trunk/Makefile.in
> > URL: http://svn.apache.org/viewvc/subversion/trunk/Makefile.in?rev=1054087&r1=1054086&r2=1054087&view=diff
> > ==============================================================================
> > --- subversion/trunk/Makefile.in (original)
> > +++ subversion/trunk/Makefile.in Fri Dec 31 11:01:56 2010
> > @@ -702,6 +702,12 @@ install-man:
> > install-swig-py: install-swig-py-lib
> > install-swig-rb: install-swig-rb-lib
> >
> > +check-SWIG:
> > + if [ "$(SWIG)" = "none" ]; then \
> > + echo "SWIG disabled at configure time" >&2; \
> > + exit 1; \
> > + fi
> > +
>
> Release tarballs contain files pregenerated by SWIG. This revision probably breaks support
> for building SWIG-based bindings from release tarballs when SWIG is not available.
>
Thanks for pointing that out.
The problem I attempted to fix was that, in my trunk working copies
(which I, most of the time, configure --without-swig), running
'make swig-foo' would attempt to run a command called "none". (This is
because configure sets SWIG, which normally points to a 'swig' binary,
to 'none'.)
I'm sure there is a cleaner solution somewhere, but I don't have any
ideas right now. (I could look later for a better place to move this
check to, but a quick browse through the Makefile hasn't unearthed it
for me.) Do you have any suggestions as to a fix?