You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/03/17 07:01:41 UTC

[GitHub] [libcloud] karantan opened a new pull request #1570: Fix null value in DigitalOcean create a record

karantan opened a new pull request #1570:
URL: https://github.com/apache/libcloud/pull/1570


   ## Fix null value in DigitalOcean create a record
   
   ### Description
   
   This fixes "field could not be unmarshalled" error when trying to send
   'null' as a boolean value. It needs to be int or bool, not a string.
   
   Ref: https://developers.digitalocean.com/documentation/v2/#create-a-new-domain-record
   
   ### Status
   
   Replace this: describe the PR status. Examples:
   
   - done, ready for review
   
   ### Checklist (tick everything that applies)
   
   - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
   - [x] Documentation
   - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - ~[ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)~
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami commented on pull request #1570: Fix null value in DigitalOcean create a record

Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1570:
URL: https://github.com/apache/libcloud/pull/1570#issuecomment-830873745


   I see ``update_record()`` does the same thing so I will update that code as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami merged pull request #1570: Fix null value in DigitalOcean create a record

Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1570:
URL: https://github.com/apache/libcloud/pull/1570


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org