You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Dimitri Unruh (JIRA)" <ji...@apache.org> on 2007/03/30 12:43:25 UTC

[jira] Created: (OFBIZ-857) Remove sessionid for Googlebot & Co.

Remove sessionid for Googlebot & Co.
------------------------------------

                 Key: OFBIZ-857
                 URL: https://issues.apache.org/jira/browse/OFBIZ-857
             Project: OFBiz (The Open for Business Project)
          Issue Type: New Feature
          Components: framework
            Reporter: Dimitri Unruh
            Priority: Minor


Hi,

I guess it's a good thing to remove the sessionId from all links, if the current request is searchbot...

Thank you.

Dimitri Unruh

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Assigned: (OFBIZ-857) Remove sessionid for Googlebot & Co.

Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks for feedback Rohit,

I will have a closer look soon (hopefully friday). Please in such case
post a comment in the Jira issue instead (for history reason), thanks (I
did it for you this time ;o)

Jacques

----- Message d'origine ----- 
De : "rohit2006" <ro...@yahoo.com>
À : <de...@ofbiz.apache.org>
Envoyé : lundi 11 juin 2007 07:08
Objet : Re: [jira] Assigned: (OFBIZ-857) Remove sessionid for Googlebot
& Co.


>
> hi Jacques,
>
> i have used this feature in a test environment for about a month and
did not
> have any issue, if no have issues have been reported, i believe the
patch
> may be committed.
>
> Rohit
>
>
> JIRA jira@apache.org wrote:
> >
> >
> >      [
> >
https://issues.apache.org/jira/browse/OFBIZ-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > ]
> >
> > Jacques Le Roux reassigned OFBIZ-857:
> > -------------------------------------
> >
> >     Assignee: Jacques Le Roux
> >
> >> Remove sessionid for Googlebot & Co.
> >> ------------------------------------
> >>
> >>                 Key: OFBIZ-857
> >>                 URL:
https://issues.apache.org/jira/browse/OFBIZ-857
> >>             Project: OFBiz (The Open for Business Project)
> >>          Issue Type: New Feature
> >>          Components: framework
> >>            Reporter: Dimitri Unruh
> >>         Assigned To: Jacques Le Roux
> >>            Priority: Minor
> >>         Attachments: patch.patch
> >>
> >>
> >> Hi,
> >> I guess it's a good thing to remove the sessionId from all links,
if the
> >> current request is searchbot...
> >> Thank you.
> >> Dimitri Unruh
> >
> > -- 
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
> >
>
> -- 
> View this message in context:
http://www.nabble.com/-jira--Created%3A-%28OFBIZ-857%29-Remove-sessionid-for-Googlebot---Co.-tf3491443.html#a11055104
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.


Re: [jira] Assigned: (OFBIZ-857) Remove sessionid for Googlebot & Co.

Posted by rohit2006 <ro...@yahoo.com>.
hi Jacques,

i have used this feature in a test environment for about a month and did not
have any issue, if no have issues have been reported, i believe the patch
may be committed.

Rohit
  

JIRA jira@apache.org wrote:
> 
> 
>      [
> https://issues.apache.org/jira/browse/OFBIZ-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
> 
> Jacques Le Roux reassigned OFBIZ-857:
> -------------------------------------
> 
>     Assignee: Jacques Le Roux
> 
>> Remove sessionid for Googlebot & Co.
>> ------------------------------------
>>
>>                 Key: OFBIZ-857
>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-857
>>             Project: OFBiz (The Open for Business Project)
>>          Issue Type: New Feature
>>          Components: framework
>>            Reporter: Dimitri Unruh
>>         Assigned To: Jacques Le Roux
>>            Priority: Minor
>>         Attachments: patch.patch
>>
>>
>> Hi,
>> I guess it's a good thing to remove the sessionId from all links, if the
>> current request is searchbot...
>> Thank you.
>> Dimitri Unruh
> 
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
> 
> 
> 

-- 
View this message in context: http://www.nabble.com/-jira--Created%3A-%28OFBIZ-857%29-Remove-sessionid-for-Googlebot---Co.-tf3491443.html#a11055104
Sent from the OFBiz - Dev mailing list archive at Nabble.com.


[jira] Commented: (OFBIZ-857) Remove sessionid for Googlebot & Co.

Posted by "Dimitri Unruh (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485501 ] 

Dimitri Unruh commented on OFBIZ-857:
-------------------------------------

The patch should resolve this issue...


Regards

Dimitri Unruh

> Remove sessionid for Googlebot & Co.
> ------------------------------------
>
>                 Key: OFBIZ-857
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-857
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Dimitri Unruh
>            Priority: Minor
>         Attachments: patch.txt
>
>
> Hi,
> I guess it's a good thing to remove the sessionId from all links, if the current request is searchbot...
> Thank you.
> Dimitri Unruh

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-857) Remove sessionid for Googlebot & Co.

Posted by "Dimitri Unruh (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dimitri Unruh updated OFBIZ-857:
--------------------------------

    Attachment: patch.patch

the previos one had a wrong file extension :)

> Remove sessionid for Googlebot & Co.
> ------------------------------------
>
>                 Key: OFBIZ-857
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-857
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Dimitri Unruh
>            Priority: Minor
>         Attachments: patch.patch, patch.txt
>
>
> Hi,
> I guess it's a good thing to remove the sessionId from all links, if the current request is searchbot...
> Thank you.
> Dimitri Unruh

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (OFBIZ-857) Remove sessionid for Googlebot & Co.

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-857:
-----------------------------------


This issue was closed, don't know why.

> Remove sessionid for Googlebot & Co.
> ------------------------------------
>
>                 Key: OFBIZ-857
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-857
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Dimitri Unruh
>            Priority: Minor
>         Attachments: patch.patch
>
>
> Hi,
> I guess it's a good thing to remove the sessionId from all links, if the current request is searchbot...
> Thank you.
> Dimitri Unruh

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-857) Remove sessionid for Googlebot & Co.

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507792 ] 

Jacques Le Roux commented on OFBIZ-857:
---------------------------------------

Dimitri, Rohit,

I had some troubles to apply the pach (was a bit old) and please Dimitri don' t use tabs in your patches but four spaces (please read carefully http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices).

So I have aapplied the patch loacally to demo instance I use on my dev. machine and will test it a bit before commiting...

Thanks to both

> Remove sessionid for Googlebot & Co.
> ------------------------------------
>
>                 Key: OFBIZ-857
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-857
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Dimitri Unruh
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: patch.patch
>
>
> Hi,
> I guess it's a good thing to remove the sessionId from all links, if the current request is searchbot...
> Thank you.
> Dimitri Unruh

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OFBIZ-857) Remove sessionid for Googlebot & Co.

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-857:
-------------------------------------

    Assignee: Jacques Le Roux

> Remove sessionid for Googlebot & Co.
> ------------------------------------
>
>                 Key: OFBIZ-857
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-857
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Dimitri Unruh
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>         Attachments: patch.patch
>
>
> Hi,
> I guess it's a good thing to remove the sessionId from all links, if the current request is searchbot...
> Thank you.
> Dimitri Unruh

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-857) Remove sessionid for Googlebot & Co.

Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507883 ] 

David E. Jones commented on OFBIZ-857:
--------------------------------------

I took a quick peek at this patch and I think the approach used looks good and shouldn't interfere with other stuff.

+1 from me.

> Remove sessionid for Googlebot & Co.
> ------------------------------------
>
>                 Key: OFBIZ-857
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-857
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Dimitri Unruh
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: patch.patch
>
>
> Hi,
> I guess it's a good thing to remove the sessionId from all links, if the current request is searchbot...
> Thank you.
> Dimitri Unruh

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-857) Remove sessionid for Googlebot & Co.

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507885 ] 

Jacques Le Roux commented on OFBIZ-857:
---------------------------------------

Thanks for comment David,

Yes, that was my 1st impression too. I will commit it tomorrow morning I guess. Just to have a look at the log tonight...

> Remove sessionid for Googlebot & Co.
> ------------------------------------
>
>                 Key: OFBIZ-857
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-857
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Dimitri Unruh
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: patch.patch
>
>
> Hi,
> I guess it's a good thing to remove the sessionId from all links, if the current request is searchbot...
> Thank you.
> Dimitri Unruh

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OFBIZ-857) Remove sessionid for Googlebot & Co.

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-857.
---------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks Dimitri,

You patch is in trunk rev. 550673  


> Remove sessionid for Googlebot & Co.
> ------------------------------------
>
>                 Key: OFBIZ-857
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-857
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Dimitri Unruh
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: patch.patch
>
>
> Hi,
> I guess it's a good thing to remove the sessionId from all links, if the current request is searchbot...
> Thank you.
> Dimitri Unruh

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-857) Remove sessionid for Googlebot & Co.

Posted by "Dimitri Unruh (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dimitri Unruh updated OFBIZ-857:
--------------------------------

    Attachment: patch.txt

> Remove sessionid for Googlebot & Co.
> ------------------------------------
>
>                 Key: OFBIZ-857
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-857
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Dimitri Unruh
>            Priority: Minor
>         Attachments: patch.txt
>
>
> Hi,
> I guess it's a good thing to remove the sessionId from all links, if the current request is searchbot...
> Thank you.
> Dimitri Unruh

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-857) Remove sessionid for Googlebot & Co.

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503804 ] 

Jacques Le Roux commented on OFBIZ-857:
---------------------------------------

Comment from Rohitk Sureka on ML :

I have used this feature in a test environment for about a month and did not have any issue, if no have issues have been reported, i believe the patch may be committed

> Remove sessionid for Googlebot & Co.
> ------------------------------------
>
>                 Key: OFBIZ-857
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-857
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Dimitri Unruh
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: patch.patch
>
>
> Hi,
> I guess it's a good thing to remove the sessionId from all links, if the current request is searchbot...
> Thank you.
> Dimitri Unruh

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-857) Remove sessionid for Googlebot & Co.

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-857:
----------------------------------

    Attachment:     (was: patch.txt)

> Remove sessionid for Googlebot & Co.
> ------------------------------------
>
>                 Key: OFBIZ-857
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-857
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Dimitri Unruh
>            Priority: Minor
>         Attachments: patch.patch
>
>
> Hi,
> I guess it's a good thing to remove the sessionId from all links, if the current request is searchbot...
> Thank you.
> Dimitri Unruh

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (OFBIZ-857) Remove sessionid for Googlebot & Co.

Posted by "Dimitri Unruh (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dimitri Unruh resolved OFBIZ-857.
---------------------------------

    Resolution: Fixed

Could someone please review this patch?!


Kind regards

Dimitri Unruh

> Remove sessionid for Googlebot & Co.
> ------------------------------------
>
>                 Key: OFBIZ-857
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-857
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Dimitri Unruh
>            Priority: Minor
>         Attachments: patch.patch, patch.txt
>
>
> Hi,
> I guess it's a good thing to remove the sessionId from all links, if the current request is searchbot...
> Thank you.
> Dimitri Unruh

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.