[GitHub] [thrift] ulidtko commented on pull request #2160: THRIFT-5132 Warning in TSocket when using ssl connection

[GitBox <gi...@apache.org>]

ulidtko commented on pull request #2160:
URL: https://github.com/apache/thrift/pull/2160#issuecomment-669785048


   @sveneld can you please specify exact steps to reproduce? I don't get any warning even on [several builds of] 7.3.14.
   
   ```
   $ cd thrift_clone_dir/lib/php
   $
   $ cat > test.php <<EOF
   <?php
   require "Thrift/Type/TType.php";
   require "Thrift/Transport/TTransport.php";
   require "Thrift/Transport/TSocket.php";
   require "Thrift/Exception/TException.php";
   
   $buzz = new Thrift\Transport\TSocket('ssl://ifconfig.me', 443);
   $buzz->open();
   var_dump($buzz);
   ?>
   EOF
   $
   $ docker run --rm -it -v $PWD/test.php:/test.php -v $PWD/lib:/usr/local/lib/php/Thrift:ro -w $PWD php:7.3.14 php -f /test.php
   object(Thrift\Transport\TSocket)#1 (10) {
     ["handle_":protected]=>
     resource(8) of type (stream)
     ["host_":protected]=>
     string(17) "ssl://ifconfig.me"
     ["port_":protected]=>
     int(443)
     ["sendTimeoutSec_":protected]=>
     int(0)
     ["sendTimeoutUsec_":protected]=>
     int(100000)
     ["recvTimeoutSec_":protected]=>
     int(0)
     ["recvTimeoutUsec_":protected]=>
     int(750000)
     ["persist_":protected]=>
     bool(false)
     ["debug_":protected]=>
     bool(false)
     ["debugHandler_":protected]=>
     string(9) "error_log"
   }
   ```
   
   See, no warnings.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org