You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2023/04/27 03:55:51 UTC

[GitHub] [spark] cloud-fan commented on a diff in pull request #40739: [SPARK-43302][SQL] Make Python UDAF an AggregateFunction

cloud-fan commented on code in PR #40739:
URL: https://github.com/apache/spark/pull/40739#discussion_r1178598100


##########
sql/core/src/test/resources/sql-tests/results/udaf/udaf-group-by-ordinal.sql.out:
##########
@@ -93,12 +93,19 @@ struct<>
 -- !query output
 org.apache.spark.sql.AnalysisException
 {
-  "errorClass" : "MISSING_AGGREGATION",
-  "sqlState" : "42803",
+  "errorClass" : "GROUP_BY_POS_AGGREGATE",

Review Comment:
   now the error is the same as normal expressions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org