You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/28 21:13:34 UTC
[GitHub] [druid] rash67 opened a new pull request, #13154: Refactor CompressedBigDecimal Sum/Min/Max
rash67 opened a new pull request, #13154:
URL: https://github.com/apache/druid/pull/13154
### Description
Refactor CompressedBigDecimal Sum/Min/Max
This refactors several of the classes for production code as well as
shared test cases across all 3 functions.
Every case of production and test instances that exist for all three
functions has a base class. Often this doesn't reduce loc significantly,
but ensures that common behavior can be controlled in one location
(eg AggregatorFactory.finalizeComputation(),
AggregatorFactory.getCacheKey)
##### Key changed/added classes in this PR
All new classes in this commit matching *Base both in production code
and test code.
<hr>
This PR has:
- [X] been self-reviewed.
- [X ] added documentation for new or modified features or behaviors.
- [X ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ X] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ X] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] rash67 commented on pull request #13154: Refactor CompressedBigDecimal Sum/Min/Max
Posted by GitBox <gi...@apache.org>.
rash67 commented on PR #13154:
URL: https://github.com/apache/druid/pull/13154#issuecomment-1264022284
per discussion with @cheddar , this has been merged into PR #13141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] rash67 closed pull request #13154: Refactor CompressedBigDecimal Sum/Min/Max
Posted by GitBox <gi...@apache.org>.
rash67 closed pull request #13154: Refactor CompressedBigDecimal Sum/Min/Max
URL: https://github.com/apache/druid/pull/13154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org