You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/18 05:40:51 UTC
[GitHub] [arrow-datafusion] Ted-Jiang opened a new pull request #1463: fix calculate in many_to_many_hash_partition test.
Ted-Jiang opened a new pull request #1463:
URL: https://github.com/apache/arrow-datafusion/pull/1463
# Which issue does this PR close?
#1462
Closes #.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Ted-Jiang removed a comment on pull request #1463: fix calculate in many_to_many_hash_partition test.
Posted by GitBox <gi...@apache.org>.
Ted-Jiang removed a comment on pull request #1463:
URL: https://github.com/apache/arrow-datafusion/pull/1463#issuecomment-997206266
>
Thanks, how do i check this before commit ? i can not find in `Developer's guide` 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan merged pull request #1463: fix calculate in many_to_many_hash_partition test.
Posted by GitBox <gi...@apache.org>.
Dandandan merged pull request #1463:
URL: https://github.com/apache/arrow-datafusion/pull/1463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #1463: fix calculate in many_to_many_hash_partition test.
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #1463:
URL: https://github.com/apache/arrow-datafusion/pull/1463#issuecomment-997211841
Thank you @Ted-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #1463: fix calculate in many_to_many_hash_partition test.
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #1463:
URL: https://github.com/apache/arrow-datafusion/pull/1463#issuecomment-997211788
> > @Ted-Jiang great find/fix! there is one clippy error:
> > ```rust
> > --> datafusion/src/physical_plan/repartition.rs:581:24
> > |
> > 581 | .map(|x| x.into_iter().map(|x| x.num_rows()).sum::<usize>())
> > | ^^^^^^^^^ help: call directly: `iter`
> > |
> > = note: `-D clippy::into-iter-on-ref` implied by `-D warnings`
> > ```
>
> Thanks, how do i check this before commit ? i can not find in `Developer's guide` 😂
You can run `cargo clippy`
> > @Ted-Jiang great find/fix! there is one clippy error:
> > ```rust
> > --> datafusion/src/physical_plan/repartition.rs:581:24
> > |
> > 581 | .map(|x| x.into_iter().map(|x| x.num_rows()).sum::<usize>())
> > | ^^^^^^^^^ help: call directly: `iter`
> > |
> > = note: `-D clippy::into-iter-on-ref` implied by `-D warnings`
> > ```
>
> Thanks, how do i check this before commit ? i can not find in `Developer's guide` 😂
You can run `cargo clippy` and you get the warnings 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Ted-Jiang commented on pull request #1463: fix calculate in many_to_many_hash_partition test.
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on pull request #1463:
URL: https://github.com/apache/arrow-datafusion/pull/1463#issuecomment-997206335
> @Ted-Jiang great find/fix! there is one clippy error:
>
> ```rust
> --> datafusion/src/physical_plan/repartition.rs:581:24
> |
> 581 | .map(|x| x.into_iter().map(|x| x.num_rows()).sum::<usize>())
> | ^^^^^^^^^ help: call directly: `iter`
> |
> = note: `-D clippy::into-iter-on-ref` implied by `-D warnings`
> ```
Thanks, how do i check this before commit ? i can not find in `Developer's guide` 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Ted-Jiang commented on pull request #1463: fix calculate in many_to_many_hash_partition test.
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on pull request #1463:
URL: https://github.com/apache/arrow-datafusion/pull/1463#issuecomment-997206266
>
Thanks, how do i check this before commit ? i can not find in `Developer's guide` 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #1463: fix calculate in many_to_many_hash_partition test.
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #1463:
URL: https://github.com/apache/arrow-datafusion/pull/1463#issuecomment-997188369
@Ted-Jiang great find/fix! there is one clippy error:
```rust
--> datafusion/src/physical_plan/repartition.rs:581:24
|
581 | .map(|x| x.into_iter().map(|x| x.num_rows()).sum::<usize>())
| ^^^^^^^^^ help: call directly: `iter`
|
= note: `-D clippy::into-iter-on-ref` implied by `-D warnings`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org