[GitHub] [hive] deniskuzZ commented on a change in pull request #2062: HIVE-24874: Worker performance metric

[GitBox <gi...@apache.org>]

deniskuzZ commented on a change in pull request #2062:
URL: https://github.com/apache/hive/pull/2062#discussion_r595260109



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -97,12 +99,14 @@ public static String hostname() {
   public void run() {
     LOG.info("Starting Worker thread");
     boolean computeStats = conf.getBoolVar(HiveConf.ConfVars.HIVE_MR_COMPACTOR_GATHER_STATS);
+    boolean metricsEnabled = conf.getBoolVar(HiveConf.ConfVars.HIVE_SERVER2_METRICS_ENABLED);

Review comment:
       fixed

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -390,9 +392,12 @@ private ExecutorService getTimeoutHandlingExecutor() {
    * @throws InterruptedException is thrown when the process is interrupted because of timeout for example
    */
   @VisibleForTesting
-  protected Boolean findNextCompactionAndExecute(boolean computeStats) throws InterruptedException {
+  protected Boolean findNextCompactionAndExecute(boolean computeStats) {

Review comment:
       fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org