You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "sgup432 (via GitHub)" <gi...@apache.org> on 2026/03/10 22:06:56 UTC
[PR] Replace BigInteger allocation in StringHelper.idToString with HexFormat [lucene]
sgup432 opened a new pull request, #15807:
URL: https://github.com/apache/lucene/pull/15807
### Description
While going through [PR](https://github.com/apache/lucene/pull/15805) where we are reducing lock contention, and me further questioning the existence of BigInteger, I stumbled upon the method `StringHelper.idToString()` which unnecessarily allocates BigInteger just to render a 16-byte ID as a base-36 string for debugging.
HexFormat got available in JDK17+, maybe we can use that now? And is better.
Minor change, no impact on performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Replace BigInteger allocation in StringHelper.idToString with HexFormat [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss merged PR #15807:
URL: https://github.com/apache/lucene/pull/15807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Replace BigInteger allocation in StringHelper.idToString with HexFormat [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #15807:
URL: https://github.com/apache/lucene/pull/15807#issuecomment-4040790223
Yes, please include it. Maybe we should even target 10x? In this case, put it under changes to 10.5.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Replace BigInteger allocation in StringHelper.idToString with HexFormat [lucene]
Posted by "sgup432 (via GitHub)" <gi...@apache.org>.
sgup432 commented on PR #15807:
URL: https://github.com/apache/lucene/pull/15807#issuecomment-4041207492
@dweiss Added changelog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Replace BigInteger allocation in StringHelper.idToString with HexFormat [lucene]
Posted by "sgup432 (via GitHub)" <gi...@apache.org>.
sgup432 commented on PR #15807:
URL: https://github.com/apache/lucene/pull/15807#issuecomment-4040705046
@dweiss Do we need a changelog for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org