You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/01 18:39:27 UTC

[GitHub] [kafka] mjsax commented on a change in pull request #8565: KAFKA-9798: Send one round synchronously before starting the async producer

mjsax commented on a change in pull request #8565:
URL: https://github.com/apache/kafka/pull/8565#discussion_r418678556



##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/QueryableStateIntegrationTest.java
##########
@@ -1262,6 +1266,7 @@ public void run() {
                     }
                     incrementIteration();
                 }
+                producer.flush();

Review comment:
       The producer is create using try-with-resource clause thus, the producer should be flushed on the implicit `close()` anyway? Thus, I don't think explicit flushing would help?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org