You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2021/08/07 22:22:24 UTC
[GitHub] [fluo-muchos] arvindshmicrosoft opened a new pull request #404: Update Ansible (Azure) version
arvindshmicrosoft opened a new pull request #404:
URL: https://github.com/apache/fluo-muchos/pull/404
* Update to ansible-core (2.11.3), ansible-lint (5.1.2)
* Switch to using community-contributed Azure VMSS Ansible module
* Update README to include steps for installing the Azure Ansible
modules from Ansible Galaxy
* Update CI to align with above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on pull request #404: Update Ansible (Azure) version
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on pull request #404:
URL: https://github.com/apache/fluo-muchos/pull/404#issuecomment-894713718
Related TODOs: #341 and #405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #404: Update Ansible (Azure) version
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on a change in pull request #404:
URL: https://github.com/apache/fluo-muchos/pull/404#discussion_r686115888
##########
File path: ansible/roles/azure/tasks/create_vmss.yml
##########
@@ -40,7 +40,7 @@
when: numnodes > 100
- name: Create Scale Set
- azure_rm_virtualmachinescaleset:
+ community.azure.azure_rm_virtualmachinescaleset:
Review comment:
My eventual goal is to support Spot VMSS instances, and that in turn requires this module. Hence thinking forward I figured it might be okay to change this right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] karthick-rn commented on a change in pull request #404: Update Ansible (Azure) version
Posted by GitBox <gi...@apache.org>.
karthick-rn commented on a change in pull request #404:
URL: https://github.com/apache/fluo-muchos/pull/404#discussion_r685933098
##########
File path: ansible/roles/azure/tasks/create_vmss.yml
##########
@@ -40,7 +40,7 @@
when: numnodes > 100
- name: Create Scale Set
- azure_rm_virtualmachinescaleset:
+ community.azure.azure_rm_virtualmachinescaleset:
Review comment:
[https://docs.ansible.com/ansible/latest/collections/azure/azcollection/azure_rm_virtualmachinescaleset_module.html](url)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft merged pull request #404: Update Ansible (Azure) version
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft merged pull request #404:
URL: https://github.com/apache/fluo-muchos/pull/404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on pull request #404: Update Ansible (Azure) version
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on pull request #404:
URL: https://github.com/apache/fluo-muchos/pull/404#issuecomment-896270015
Thank you @karthick-rn and @ctubbsii.
I wonder if @milleruntime or others who have access to an AWS account can do a sanity check with this commit? I am fairly confident that these changes are completely localized to the Azure provisioning code, but if possible it would be great to get a quick sanity run on AWS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] karthick-rn commented on a change in pull request #404: Update Ansible (Azure) version
Posted by GitBox <gi...@apache.org>.
karthick-rn commented on a change in pull request #404:
URL: https://github.com/apache/fluo-muchos/pull/404#discussion_r685932910
##########
File path: ansible/roles/azure/tasks/create_vmss.yml
##########
@@ -40,7 +40,7 @@
when: numnodes > 100
- name: Create Scale Set
- azure_rm_virtualmachinescaleset:
+ community.azure.azure_rm_virtualmachinescaleset:
Review comment:
Hi @arvindshmicrosoft, Is the prefix mandatory? The same module seems to exist in `azure.azcollection` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] ctubbsii commented on pull request #404: Update Ansible (Azure) version
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #404:
URL: https://github.com/apache/fluo-muchos/pull/404#issuecomment-896942830
> I wonder if @milleruntime or others who have access to an AWS account can do a sanity check with this commit? I am fairly confident that these changes are completely localized to the Azure provisioning code, but if possible it would be great to get a quick sanity run on AWS.
I don't see anything that could even conceivably apply to AWS. If you want to just merge this, go ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] karthick-rn commented on a change in pull request #404: Update Ansible (Azure) version
Posted by GitBox <gi...@apache.org>.
karthick-rn commented on a change in pull request #404:
URL: https://github.com/apache/fluo-muchos/pull/404#discussion_r685932910
##########
File path: ansible/roles/azure/tasks/create_vmss.yml
##########
@@ -40,7 +40,7 @@
when: numnodes > 100
- name: Create Scale Set
- azure_rm_virtualmachinescaleset:
+ community.azure.azure_rm_virtualmachinescaleset:
Review comment:
Hi @arvindshmicrosoft, Is the prefix mandatory? The same module seems to exist in [azure.azcollection](https://docs.ansible.com/ansible/latest/collections/azure/azcollection/azure_rm_virtualmachinescaleset_module.html) as well.
##########
File path: ansible/roles/azure/tasks/create_vmss.yml
##########
@@ -40,7 +40,7 @@
when: numnodes > 100
- name: Create Scale Set
- azure_rm_virtualmachinescaleset:
+ community.azure.azure_rm_virtualmachinescaleset:
Review comment:
[https://docs.ansible.com/ansible/latest/collections/azure/azcollection/azure_rm_virtualmachinescaleset_module.html](url)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@fluo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org