[jira] [Commented] (LUCENE-9460) getPath in DirectoryTaxonomyReader should throw an exception

["Gautam Worah (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407660#comment-17407660 ] 

Gautam Worah commented on LUCENE-9460:
--------------------------------------

We are addressing this in this LUCENE-9476 [PR|https://github.com/apache/lucene/pull/179]

> getPath in DirectoryTaxonomyReader should throw an exception
> ------------------------------------------------------------
>
>                 Key: LUCENE-9460
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9460
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>    Affects Versions: 8.5.2
>            Reporter: Gautam Worah
>            Priority: Trivial
>
> This issue is a spillover from [LUCENE-9450 PR|https://github.com/apache/lucene-solr/pull/1733] and was suggested by [~mikemccand]
> If the {{ordinal}} is out of bound it indicates that the user called their main {{IndexReader}} and the {{TaxonomyReader}} in the wrong order. 
> In this case, we should throw an {{IllegalArgumentException}} to warn the user instead of returning {{null}}
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org