You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/03/14 01:45:54 UTC
[GitHub] [arrow] wgtmac opened a new pull request, #34553: GH-34552: Sync parquet.thrift from upstream
wgtmac opened a new pull request, #34553:
URL: https://github.com/apache/arrow/pull/34553
### Rationale for this change
The parquet.thrift file has been updated with various comments to minimize confusion or misuse about crc, page padding, and NaN handling. These are essential guidelines for recent changes in the parquet-cpp. Therefore it is a good time to sync this file.
In addition, the generated sources were built with thrift 0.13. We should rebuild them with latest thrift tool to embrace modern cpp.
### What changes are included in this PR?
- Update `parquet.thrift` file from latest `apache/parquet-format` repo.
- Build it with thrift 0.17.
### Are these changes tested?
Make sure all tests pass.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34553: GH-34552: [C++][Parquet] Sync parquet.thrift from upstream
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34553:
URL: https://github.com/apache/arrow/pull/34553#issuecomment-1469000912
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/fff6f7f0873243e7854566819aad5122...a73417855f02437db80214c9889b4d19/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34553: GH-34552: [C++][Parquet] Sync parquet.thrift from upstream
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34553:
URL: https://github.com/apache/arrow/pull/34553#issuecomment-1467217551
* Closes: #34552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wgtmac commented on pull request #34553: GH-34552: [C++][Parquet] Sync parquet.thrift from upstream
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #34553:
URL: https://github.com/apache/arrow/pull/34553#issuecomment-1467596825
@westonpace @wjones127 @pitrou @emkornfield Could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 merged pull request #34553: GH-34552: [C++][Parquet] Sync parquet.thrift from upstream
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 merged PR #34553:
URL: https://github.com/apache/arrow/pull/34553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34553: GH-34552: [C++][Parquet] Sync parquet.thrift from upstream
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34553:
URL: https://github.com/apache/arrow/pull/34553#issuecomment-1467217581
:warning: GitHub issue #34552 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34553: GH-34552: [C++][Parquet] Sync parquet.thrift from upstream
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34553:
URL: https://github.com/apache/arrow/pull/34553#issuecomment-1468997031
Benchmark runs are scheduled for baseline = 44edc27e549d82db930421b0d4c76098941afd71 and contender = b7fa29bc6f934848ce4946f408cbc8fa98ae784b. b7fa29bc6f934848ce4946f408cbc8fa98ae784b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a352a5d3951c4e5389244094a09b4ff7...f7d267aff1384ebfb2264ad05e447450/)
[Failed :arrow_down:0.45% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fff6f7f0873243e7854566819aad5122...a73417855f02437db80214c9889b4d19/)
[Finished :arrow_down:0.26% :arrow_up:0.51%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/fe0d64be1b4b4b73b134d4f3d2e9d4a5...05aa0d689c224872939028a8c8d0b16f/)
[Finished :arrow_down:1.07% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/74e48f7b404f49d5a46709e56071227b...9b4fc2a2352c4421b2264deae3a6ac3a/)
Buildkite builds:
[Finished] [`b7fa29bc` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2523)
[Failed] [`b7fa29bc` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2553)
[Finished] [`b7fa29bc` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2521)
[Finished] [`b7fa29bc` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2544)
[Finished] [`44edc27e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2522)
[Failed] [`44edc27e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2552)
[Finished] [`44edc27e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2520)
[Finished] [`44edc27e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2543)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org