Re: [I] parquet-reader outputting invalid JSON [arrow]

["stackedsax (via GitHub)" <gi...@apache.org>]

stackedsax commented on issue #47668:
URL: https://github.com/apache/arrow/issues/47668#issuecomment-5981235919

   This was fixed upstream in #44532 (GH-44101), released in Arrow 19.0.0. The malformed `ColumnIndex {...}"` output came from a stray string literal in `printer.cc` introduced by #38860 (18.0.0); #44532 corrected it to emit `"ColumnIndex": {"offset": ..., "length": ...}`.
   
   Since then the printer has been migrated to a proper `JsonWriter` (#50877, #50990), so malformed keys of this kind are structurally impossible now, and #47190 added a `ValidJsonOutput` test in `reader_test.cc` that parses the printer's output to make sure it stays valid JSON.
   
   ClickHouse's fork (ClickHouse/arrow#72, linked above) is based on `release/16.1.0`, which predates the fix, so the fork would need to rebase or cherry-pick f5691d467c rather than anything changing here.
   
   @thisisnic I think this one can be closed as fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org