You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by gi...@git.apache.org on 2017/09/08 21:30:56 UTC

[GitHub] sergeykolychev commented on a change in pull request #7815: [Perl] reduce buffer copies in NDArray<->PDL conversions

sergeykolychev commented on a change in pull request #7815: [Perl] reduce buffer copies in NDArray<->PDL conversions
URL: https://github.com/apache/incubator-mxnet/pull/7815#discussion_r137893966
 
 

 ##########
 File path: perl-package/AI-MXNet/lib/AI/MXNet/NDArray.pm
 ##########
 @@ -208,17 +208,13 @@ method _sync_copyfrom(ArrayRef|PDL|PDL::Matrix $source_array)
         confess("Shape inconsistant: expected $ndary_shape_str vs got $pdl_shape_str")
     }
     my $perl_pack_type = DTYPE_MX_TO_PERL->{$dtype};
 
 Review comment:
   Please remove $perl_pack_type from the subs, as they became unused
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services