You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2017/01/12 20:51:32 UTC

Review Request 55468: AMBARI-19390 : AMS Collector works in HTTP mode after setting ams-site/timeline.metrics.service.http.policy=HTTPS_ONLY to HTTPS_ONLY

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55468/
-----------------------------------------------------------

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-19390
    https://issues.apache.org/jira/browse/AMBARI-19390


Repository: ambari


Description
-------

PROBLEM
AMS Collector works in HTTP mode after setting ams-site/timeline.metrics.service.http.policy=HTTPS_ONLY to HTTPS_ONLY. This is because the STOP/START commands failed.

BUG
In JDK 7 if there are multiple certificates in the keystore, we need to explicitly give the alias of the certificate we want to import. 
Since this cluster had certificates for all hosts in the cluster, the JKS -> PKCS12 conversion did not work. In JDK 8, this is not needed.


Diffs
-----

  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-ssl-client.xml 3f28f9f 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8ce62cb 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 6d66a91 
  ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py 6a754e3 
  ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py 9ac14c4 

Diff: https://reviews.apache.org/r/55468/diff/


Testing
-------

Manually tested. Fixed unit tests to reflect this change.


Thanks,

Aravindan Vijayan


Re: Review Request 55468: AMBARI-19390 : AMS Collector works in HTTP mode after setting ams-site/timeline.metrics.service.http.policy=HTTPS_ONLY to HTTPS_ONLY

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55468/#review161415
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On Jan. 12, 2017, 8:51 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55468/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2017, 8:51 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19390
>     https://issues.apache.org/jira/browse/AMBARI-19390
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> PROBLEM
> AMS Collector works in HTTP mode after setting ams-site/timeline.metrics.service.http.policy=HTTPS_ONLY to HTTPS_ONLY. This is because the STOP/START commands failed.
> 
> BUG
> In JDK 7 if there are multiple certificates in the keystore, we need to explicitly give the alias of the certificate we want to import. 
> Since this cluster had certificates for all hosts in the cluster, the JKS -> PKCS12 conversion did not work. In JDK 8, this is not needed.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-ssl-client.xml 3f28f9f 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 8ce62cb 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 6d66a91 
>   ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py 6a754e3 
>   ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py 9ac14c4 
> 
> Diff: https://reviews.apache.org/r/55468/diff/
> 
> 
> Testing
> -------
> 
> Manually tested. Fixed unit tests to reflect this change.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>