You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/03/23 11:55:05 UTC
[kudu-CR] [docs] Add note for CM-based multi-master migration
Hello Alex Rodoni, Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9784
to review the following change.
Change subject: [docs] Add note for CM-based multi-master migration
......................................................................
[docs] Add note for CM-based multi-master migration
The migrating to multi-master guide specifies changing the
master_addresses. This step doesn't have to be done in CM-based
deployments as it will generate this list. Added a note about it.
Change-Id: Idcb3d3c0d7d0641db679a21505303b56cf29be12
---
M docs/administration.adoc
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/9784/1
--
To view, visit http://gerrit.cloudera.org:8080/9784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcb3d3c0d7d0641db679a21505303b56cf29be12
Gerrit-Change-Number: 9784
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] [docs] Add note for CM-based multi-master migration
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9784 )
Change subject: [docs] Add note for CM-based multi-master migration
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9784/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/9784/1/docs/administration.adoc@352
PS1, Line 352: NOTE: If you're using Cloudera Manager, you don't need to change `master_addresses` as it will
At one point we made an effort to remove mentions of vendor-specific tooling from our documentation. I'm not sure we want to add this back here. Perhaps Cloudera should document this in their own version of the docs?
Or perhaps we can be a little less specific and say: "NOTE: If you are using a vendor-specific tool such as Cloudera Manager to manage your cluster, please refer to that vendor's documentation for the appropriate procedure", and then Cloudera is free to document it as they see fit.
--
To view, visit http://gerrit.cloudera.org:8080/9784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb3d3c0d7d0641db679a21505303b56cf29be12
Gerrit-Change-Number: 9784
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 23 Mar 2018 16:33:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add note for CM-based multi-master migration
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9784 )
Change subject: [docs] Add note for CM-based multi-master migration
......................................................................
Patch Set 2:
(1 comment)
> Patch Set 1:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/9784/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/9784/1/docs/administration.adoc@352
PS1, Line 352:
> Yea, maybe better to just edit that part to suggest that, if using CM, it w
Done
--
To view, visit http://gerrit.cloudera.org:8080/9784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb3d3c0d7d0641db679a21505303b56cf29be12
Gerrit-Change-Number: 9784
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 26 Mar 2018 16:43:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add note for CM-based multi-master migration
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Dan Burkert, Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9784
to look at the new patch set (#2).
Change subject: [docs] Add note for CM-based multi-master migration
......................................................................
[docs] Add note for CM-based multi-master migration
The migrating to multi-master guide specifies changing the
master_addresses. This step doesn't have to be done in CM-based
deployments as it will generate this list.
Added a warning to follow Cloudera docs when using CM instead.
Change-Id: Idcb3d3c0d7d0641db679a21505303b56cf29be12
---
M docs/administration.adoc
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/9784/2
--
To view, visit http://gerrit.cloudera.org:8080/9784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idcb3d3c0d7d0641db679a21505303b56cf29be12
Gerrit-Change-Number: 9784
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [docs] Add note for CM-based multi-master migration
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9784 )
Change subject: [docs] Add note for CM-based multi-master migration
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9784/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/9784/1/docs/administration.adoc@352
PS1, Line 352: NOTE: If you're using Cloudera Manager, you don't need to change `master_addresses` as it will
> That makes sense, I didn't want to include this part first at all, but we a
Yea, maybe better to just edit that part to suggest that, if using CM, it would be better to refer to the CM documentation instead of this page, since details may differ.
--
To view, visit http://gerrit.cloudera.org:8080/9784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb3d3c0d7d0641db679a21505303b56cf29be12
Gerrit-Change-Number: 9784
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 23 Mar 2018 16:52:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add note for CM-based multi-master migration
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9784 )
Change subject: [docs] Add note for CM-based multi-master migration
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb3d3c0d7d0641db679a21505303b56cf29be12
Gerrit-Change-Number: 9784
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 23 Mar 2018 15:43:56 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add note for CM-based multi-master migration
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9784 )
Change subject: [docs] Add note for CM-based multi-master migration
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb3d3c0d7d0641db679a21505303b56cf29be12
Gerrit-Change-Number: 9784
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 05 Apr 2018 05:15:06 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add note for CM-based multi-master migration
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9784 )
Change subject: [docs] Add note for CM-based multi-master migration
......................................................................
Patch Set 1:
(1 comment)
> Patch Set 1:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/9784/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/9784/1/docs/administration.adoc@352
PS1, Line 352: NOTE: If you're using Cloudera Manager, you don't need to change `master_addresses` as it will
> At one point we made an effort to remove mentions of vendor-specific toolin
That makes sense, I didn't want to include this part first at all, but we already have this a few lines above:
WARNING: The workflow presupposes at least basic familiarity with Kudu configuration management. If
using Cloudera Manager (CM), the workflow also presupposes familiarity with it.
Should I reword this part as well?
--
To view, visit http://gerrit.cloudera.org:8080/9784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb3d3c0d7d0641db679a21505303b56cf29be12
Gerrit-Change-Number: 9784
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 23 Mar 2018 16:43:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add note for CM-based multi-master migration
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9784 )
Change subject: [docs] Add note for CM-based multi-master migration
......................................................................
[docs] Add note for CM-based multi-master migration
The migrating to multi-master guide specifies changing the
master_addresses. This step doesn't have to be done in CM-based
deployments as it will generate this list.
Added a warning to follow Cloudera docs when using CM instead.
Change-Id: Idcb3d3c0d7d0641db679a21505303b56cf29be12
Reviewed-on: http://gerrit.cloudera.org:8080/9784
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M docs/administration.adoc
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcb3d3c0d7d0641db679a21505303b56cf29be12
Gerrit-Change-Number: 9784
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>