You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pig.apache.org by ch...@apache.org on 2013/01/02 23:27:33 UTC

svn commit: r1428091 - in /pig/trunk: CHANGES.txt src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java

Author: cheolsoo
Date: Wed Jan  2 22:27:33 2013
New Revision: 1428091

URL: http://svn.apache.org/viewvc?rev=1428091&view=rev
Log:
PIG-2251: PIG leaks Zookeeper connections when using HBaseStorage (jamarkha via cheolsoo)

Modified:
    pig/trunk/CHANGES.txt
    pig/trunk/src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java

Modified: pig/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/pig/trunk/CHANGES.txt?rev=1428091&r1=1428090&r2=1428091&view=diff
==============================================================================
--- pig/trunk/CHANGES.txt (original)
+++ pig/trunk/CHANGES.txt Wed Jan  2 22:27:33 2013
@@ -64,6 +64,8 @@ PIG-3013: BinInterSedes improve chararra
 
 BUG FIXES
 
+PIG-2251: PIG leaks Zookeeper connections when using HBaseStorage (jamarkha via cheolsoo)
+
 PIG-3112: Errors and lacks in document "User Defined Functions" (miyakawataku via cheolsoo)
 
 PIG-3050: Fix FindBugs multithreading warnings (cheolsoo)

Modified: pig/trunk/src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java
URL: http://svn.apache.org/viewvc/pig/trunk/src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java?rev=1428091&r1=1428090&r2=1428091&view=diff
==============================================================================
--- pig/trunk/src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java (original)
+++ pig/trunk/src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java Wed Jan  2 22:27:33 2013
@@ -43,7 +43,6 @@ import org.apache.commons.logging.LogFac
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.fs.Path;
 import org.apache.hadoop.hbase.HBaseConfiguration;
-import org.apache.hadoop.hbase.client.HTable;
 import org.apache.hadoop.hbase.client.Put;
 import org.apache.hadoop.hbase.client.Result;
 import org.apache.hadoop.hbase.client.Scan;
@@ -147,7 +146,6 @@ public class HBaseStorage extends LoadFu
     private final static String HBASE_TOKEN_SET = "hbase.token.set";
 
     private List<ColumnInfo> columnInfo_ = Lists.newArrayList();
-    private HTable m_table;
 
     //Use JobConf to store hbase delegation token
     private JobConf m_conf;
@@ -694,9 +692,7 @@ public class HBaseStorage extends LoadFu
         if (location.startsWith("hbase://")) {
             tablename = location.substring(8);
         }
-        if (m_table == null) {
-            m_table = new HTable(m_conf, tablename);
-        }
+
         m_conf.set(TableInputFormat.INPUT_TABLE, tablename);
 
         String projectedFields = udfProps.getProperty( projectedFieldsName() );