[GitHub] [beam] lostluck commented on pull request #15323: [BEAM-5379] Go SDK modules support.

[GitBox <gi...@apache.org>]

lostluck commented on pull request #15323:
URL: https://github.com/apache/beam/pull/15323#issuecomment-897709388


   2 tests fail with the precommits:
   
   ```
   23:22:34 Test for github.com/apache/beam/sdks/v2/go/pkg/beam/artifact finished, 1 completed, 1 failed.
   23:22:37 Test for github.com/apache/beam/sdks/v2/go/pkg/beam/testing/passert finished, 29 completed, 1 failed.
   ```
   
   PostCommit build fails with:
   
   ```
   23:41:59 # golang.org/x/net/http2
   23:41:59 /home/jenkins/go/pkg/mod/golang.org/x/net@v0.0.0-20210726213435-c6fcb2dbf985/http2/client_conn_pool.go:305:6: undefined: errors.Is
   23:41:59 note: module requires Go 1.17
   ```
   
   We probably need to require an older version of that package for now (it's pulling from head, and Go 1.17 isn't released yet so that's weird).
   
   Haven't spotted what the RAT failure doesn't like other than "it's not a fan of a license". My guess is that we didn't put a general **/go.mod and **/go.sum in the RAT ignore list so it's probably complaining about the mod file in the sdks/ directory.
   
   Looking at the rest of the change now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org