You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by dm...@apache.org on 2023/02/22 11:38:24 UTC

[trafficserver] branch master updated: QUIC: Support active_connection_id_limit for quche impl. (#9449)

This is an automated email from the ASF dual-hosted git repository.

dmeden pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new f53ad5ad3 QUIC: Support active_connection_id_limit for quche impl. (#9449)
f53ad5ad3 is described below

commit f53ad5ad34dbe19e84ea36013ddea62f175a7a4e
Author: Damian Meden <dm...@apache.org>
AuthorDate: Wed Feb 22 11:38:16 2023 +0000

    QUIC: Support active_connection_id_limit for quche impl. (#9449)
---
 doc/admin-guide/files/records.yaml.en.rst | 9 ++++++++-
 iocore/net/QUICNetProcessor_quiche.cc     | 1 +
 src/records/RecordsConfig.cc              | 2 +-
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/doc/admin-guide/files/records.yaml.en.rst b/doc/admin-guide/files/records.yaml.en.rst
index 9aacf8149..12cc3231c 100644
--- a/doc/admin-guide/files/records.yaml.en.rst
+++ b/doc/admin-guide/files/records.yaml.en.rst
@@ -4410,7 +4410,7 @@ HTTP/3 Configuration
 There is no configuration available yet on this release.
 
 QUIC Configuration
-====================
+==================
 
 All configurations for QUIC are still experimental and may be changed or
 removed in the future without prior notice.
@@ -4638,6 +4638,13 @@ removed in the future without prior notice.
    This is just for debugging. Do not change it from the default value unless
    you really understand what this is.
 
+.. ts:cv:: CONFIG proxy.config.quic.active_cid_limit_in INT 2
+   :reloadable:
+
+   Integer value specifying the maximum number of connection IDs from the peer
+   that |TS| is willing to store. The value MUST be at least 2.
+   Transport Parameter.
+
 UDP Configuration
 =====================
 
diff --git a/iocore/net/QUICNetProcessor_quiche.cc b/iocore/net/QUICNetProcessor_quiche.cc
index 9e71cec2d..0910d75a2 100644
--- a/iocore/net/QUICNetProcessor_quiche.cc
+++ b/iocore/net/QUICNetProcessor_quiche.cc
@@ -99,6 +99,7 @@ QUICNetProcessor::start(int, size_t stacksize)
   quiche_config_set_initial_max_streams_bidi(this->_quiche_config, params->initial_max_streams_bidi_in());
   quiche_config_set_initial_max_streams_uni(this->_quiche_config, params->initial_max_streams_uni_in());
   quiche_config_set_disable_active_migration(this->_quiche_config, params->disable_active_migration());
+  quiche_config_set_active_connection_id_limit(this->_quiche_config, params->active_cid_limit_in());
   quiche_config_set_cc_algorithm(this->_quiche_config, QUICHE_CC_RENO);
 
 #ifdef TLS1_3_VERSION_DRAFT_TXT
diff --git a/src/records/RecordsConfig.cc b/src/records/RecordsConfig.cc
index 0355bae67..6eb326ab2 100644
--- a/src/records/RecordsConfig.cc
+++ b/src/records/RecordsConfig.cc
@@ -1433,7 +1433,7 @@ static const RecordElement RecordsConfig[] =
   ,
   {RECT_CONFIG, "proxy.config.quic.max_ack_delay_out", RECD_INT, "25", RECU_DYNAMIC, RR_NULL, RECC_STR, "^-?[0-9]+$", RECA_NULL}
   ,
-  {RECT_CONFIG, "proxy.config.quic.active_cid_limit_in", RECD_INT, "4", RECU_DYNAMIC, RR_NULL, RECC_STR, "^-?[0-9]+$", RECA_NULL}
+  {RECT_CONFIG, "proxy.config.quic.active_cid_limit_in", RECD_INT, "2", RECU_DYNAMIC, RR_NULL, RECC_STR, "^-?[0-9]+$", RECA_NULL}
   ,
   {RECT_CONFIG, "proxy.config.quic.active_cid_limit_out", RECD_INT, "8", RECU_DYNAMIC, RR_NULL, RECC_STR, "^-?[0-9]+$", RECA_NULL}
   ,