[GitHub] [ozone] Cyrill commented on a diff in pull request #5274: HDDS-9228. Poor S3G read performance

["Cyrill (via GitHub)" <gi...@apache.org>]

Cyrill commented on code in PR #5274:
URL: https://github.com/apache/ozone/pull/5274#discussion_r1322914742


##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/TracingFilter.java:
##########
@@ -71,7 +71,7 @@ public void filter(ContainerRequestContext requestContext,
     // written the data to the destination
     OutputStream out = responseContext.getEntityStream();
     if (out != null) {
-      responseContext.setEntityStream(new FilterOutputStream(out) {
+      responseContext.setEntityStream(new PureWrapperOutputStream(out) {

Review Comment:
   Wouldn't it be enough to override one more method in `FilterOutputStream` instead?
   This way:
   
   ```
   @Override
   public void write(@NotNull byte[] b, int off, int len) throws IOException {
     out.write(b, off, len);
   }
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org