[GitHub] [hbase] Apache9 commented on a change in pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#discussion_r560032645



##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java
##########
@@ -319,12 +360,18 @@ public synchronized void onChoreMissedStartTime(ScheduledChore chore) {
    * shutdown the service. Any chores that are scheduled for execution will be cancelled. Any chores
    * in the middle of execution will be interrupted and shutdown. This service will be unusable
    * after this method has been called (i.e. future scheduling attempts will fail).
+   * <p/>
+   * Notice that, this will only clean the chore from this ChoreService but you could still schedule
+   * the chore with other ChoreService.

Review comment:
       The same ChoreService has already been shutdown...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org