You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/04 07:39:02 UTC

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #24079: Add: #23880 :: Audit log for AirflowModelViews(Variables/Connection)

ephraimbuddy commented on code in PR #24079:
URL: https://github.com/apache/airflow/pull/24079#discussion_r912711945


##########
airflow/www/decorators.py:
##########
@@ -35,51 +35,56 @@
 logger = logging.getLogger(__name__)
 
 
-def action_logging(f: T) -> T:
+def action_logging(func=None, event=None):

Review Comment:
   ```suggestion
   def action_logging(func: Optional[T]=None, event: Optional[str]=None) -> T:
   ```
   Seems we need typing here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org