You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by ca...@apache.org on 2022/12/01 05:58:56 UTC
[dolphinscheduler] branch dev updated: fix issue 13035 (#13065)
This is an automated email from the ASF dual-hosted git repository.
caishunfeng pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new 12a6138d33 fix issue 13035 (#13065)
12a6138d33 is described below
commit 12a6138d3343a489069ddf98c48f61957801b167
Author: Kevin.Shin <ma...@163.com>
AuthorDate: Thu Dec 1 13:58:50 2022 +0800
fix issue 13035 (#13065)
Co-authored-by: shenk-b <sh...@glodon.com>
---
.../server/master/utils/DataQualityResultOperator.java | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DataQualityResultOperator.java b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DataQualityResultOperator.java
index c196def48a..b45833424f 100644
--- a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DataQualityResultOperator.java
+++ b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DataQualityResultOperator.java
@@ -94,7 +94,7 @@ public class DataQualityResultOperator {
private void checkDqExecuteResult(TaskEvent taskResponseEvent,
DqExecuteResult dqExecuteResult,
ProcessInstance processInstance) {
- if (isFailure(dqExecuteResult)) {
+ if (isFailed(dqExecuteResult)) {
DqFailureStrategy dqFailureStrategy = DqFailureStrategy.of(dqExecuteResult.getFailureStrategy());
if (dqFailureStrategy != null) {
dqExecuteResult.setState(DqTaskState.FAILURE.getCode());
@@ -123,7 +123,7 @@ public class DataQualityResultOperator {
* @param dqExecuteResult
* @return
*/
- private boolean isFailure(DqExecuteResult dqExecuteResult) {
+ private boolean isFailed(DqExecuteResult dqExecuteResult) {
CheckType checkType = CheckType.of(dqExecuteResult.getCheckType());
double statisticsValue = dqExecuteResult.getStatisticsValue();
@@ -132,36 +132,36 @@ public class DataQualityResultOperator {
OperatorType operatorType = OperatorType.of(dqExecuteResult.getOperator());
- boolean isFailure = false;
+ boolean isFailed = false;
if (operatorType != null) {
double srcValue = 0;
switch (checkType) {
case COMPARISON_MINUS_STATISTICS:
srcValue = comparisonValue - statisticsValue;
- isFailure = getCompareResult(operatorType, srcValue, threshold);
+ isFailed = !getCompareResult(operatorType, srcValue, threshold);
break;
case STATISTICS_MINUS_COMPARISON:
srcValue = statisticsValue - comparisonValue;
- isFailure = getCompareResult(operatorType, srcValue, threshold);
+ isFailed = !getCompareResult(operatorType, srcValue, threshold);
break;
case STATISTICS_COMPARISON_PERCENTAGE:
if (comparisonValue > 0) {
srcValue = statisticsValue / comparisonValue * 100;
}
- isFailure = getCompareResult(operatorType, srcValue, threshold);
+ isFailed = !getCompareResult(operatorType, srcValue, threshold);
break;
case STATISTICS_COMPARISON_DIFFERENCE_COMPARISON_PERCENTAGE:
if (comparisonValue > 0) {
srcValue = Math.abs(comparisonValue - statisticsValue) / comparisonValue * 100;
}
- isFailure = getCompareResult(operatorType, srcValue, threshold);
+ isFailed = !getCompareResult(operatorType, srcValue, threshold);
break;
default:
break;
}
}
- return isFailure;
+ return isFailed;
}
private void sendDqTaskResultAlert(DqExecuteResult dqExecuteResult, ProcessInstance processInstance) {