[GitHub] [cassandra] adejanovski commented on a change in pull request #488: CASSANDRA-15661 improve logging

[GitBox <gi...@apache.org>]

adejanovski commented on a change in pull request #488: CASSANDRA-15661 improve logging
URL: https://github.com/apache/cassandra/pull/488#discussion_r399194261
 
 

 ##########
 File path: src/java/org/apache/cassandra/transport/ConnectionLimitHandler.java
 ##########
 @@ -61,7 +61,7 @@ public void channelActive(ChannelHandlerContext ctx) throws Exception
         if (count > limit)
         {
             // The decrement will be done in channelClosed(...)
-            noSpamLogger.warn("Exceeded maximum native connection limit of {} by using {} connections", limit, count);
+            noSpamLogger.error("Exceeded maximum native connection limit of {} by using {} connections", limit, count);
 
 Review comment:
   I'm not sure how to use the noSpamLogger globally, because it looks like loggings that have been confusing folks a lot. You see error messages there that you can ignore (like the one with allocation for the chunk cache being impossible, which is not something that's really actionable).
   What's the intent behind the noSpamLogger and what are operators supposed to do about the messages you're raising from warn to error here?
   Is that ConnectionLimitHandler used in incremental repair?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org