You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Anil K Patel (JIRA)" <ji...@apache.org> on 2006/10/17 01:03:35 UTC
[jira] Created: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Facility-->Inventory screen is very slow, returns error if there are 10,000 products
------------------------------------------------------------------------------------
Key: OFBIZ-379
URL: http://issues.apache.org/jira/browse/OFBIZ-379
Project: OFBiz (The Open for Business Project)
Issue Type: Improvement
Components: product
Reporter: Anil K Patel
Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12443029 ]
Anil K Patel commented on OFBIZ-379:
------------------------------------
Thanks Jacopo,
It worked,
Another question, Modifications to fix this issues are dependent of http://issues.apache.org/jira/browse/OFBIZ-364.
What should we do, Submit the patch assuming that the other patch will be accepted and applied, OR submit a patch with ftl to show the list.
I have also completed the ftl thing.
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12443013 ]
Anil K Patel commented on OFBIZ-379:
------------------------------------
Si,
I am facing problem that is mentioned in http://issues.apache.org/jira/browse/OFBIZ-364 . I tried to do what Leon has suggested,
context.put("overrideFormListSize", new Integer(iterator.currentIndex()));
I am not able to figure out which attribute of form should use this data.
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12443004 ]
Anil K Patel commented on OFBIZ-379:
------------------------------------
Yes this is exactly what I am trying to do, use
prods = prodsEli.getPartialList(lowIndex, viewSize);
I am having little problem with the using form widget to show pagination navigation links. Is it ok if the list is displayed using ftl?
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12443361 ]
Anil K Patel commented on OFBIZ-379:
------------------------------------
Jacopo
Can we re-open this Issue.
I see side effects of what we have done to fix this issue. Lets say if user entered values for "QOH minus Min Stock" and/or
"ATP minus Min Stock" fields in find form. These parameters are applied to first 50 (or VIEW_SIZE) products only. Only way to apply these parameters to all inventory Items is set VIEW_SIZE (Show Products Per Page) field to 6975 in my case. If we do this I get into the old problem where all this started. The way bsh is written, I think we should review getProductInventoryAvailable service, see if there was any chance to make it faster or some how reduce number of calls to it.
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12442999 ]
Anil K Patel commented on OFBIZ-379:
------------------------------------
I tried reading 50 or 100 products at a time. It takes about 3 secs on my workstation. Which is ok. I am working on a Patch that will Read products specified by VIEW_SIZE parameter.
One problem I am facing is, The result list is displayed using form widget list form. In the new situation the size of list given to the form is limited maximum to the VIEW_SIZE, because of this pagination navigation links (Next/ Previous) are not generated. I tried to use row-count param to specify the actual size, but it does not work. One of the solution I am working on is, Redo the list display code in ftl.
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12443301 ]
Anil K Patel commented on OFBIZ-379:
------------------------------------
This works good. Thanks Jacopo.
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12443012 ]
Jacopo Cappellato commented on OFBIZ-379:
-----------------------------------------
Si,
I too would prefer to keep the form widget implementation (in this way the pdf version of the screen will continue to work :-) )
Pagination works fine for me too.
However, it is a performance issue; for example, if we have selected 10000 products, they are all processed (and the service is called 10000 times etc...) but then the form widget will just display 20 records in the screen.
So we'll have to manually implement pagination in the bsh script to speed up the report.
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=all ]
Jacopo Cappellato closed OFBIZ-379.
-----------------------------------
Resolution: Fixed
Thanks Anil,
a modified version of your patch is in svn with rev. 465283
It would be great if you could test it and see if it works fine, also with big numbers....
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12443003 ]
Jacopo Cappellato commented on OFBIZ-379:
-----------------------------------------
Anil,
instead of rewriting the list (that it is however an acceptable solution) we could also consider to use the patch in:
http://issues.apache.org/jira/browse/OFBIZ-364
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12443833 ]
Anil K Patel commented on OFBIZ-379:
------------------------------------
Jacopo,
I have partially implemented fix, Something came up (Dewali fastival) so did not get chance to work in last two days. In another two/three days I send a patch.
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12444413 ]
Anil K Patel commented on OFBIZ-379:
------------------------------------
Jacopo,
Thanks for you time. This patch looks good to me.
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip, viewproduct.patch
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12443001 ]
Jacopo Cappellato commented on OFBIZ-379:
-----------------------------------------
Maybe we can do something to improve the performance; I think that the problematic instruction is at line 128:
prods = prodsEli.getCompleteList();
The script loads in memory all the selected products, then the list is iterated at line 148.
My guess is that if we iterate the list using the EntityListIterator instead (and add the calls to the services there) and add some pagination code we should solve this problem.
Does it make sense?
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=all ]
Anil K Patel updated OFBIZ-379:
-------------------------------
Attachment: ViewFacilityInventoryByProduct.zip
This patch fixes the problem.
Dependency:
http://issues.apache.org/jira/browse/OFBIZ-364
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: ViewFacilityInventoryByProduct.zip
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=all ]
Jacopo Cappellato updated OFBIZ-379:
------------------------------------
Attachment: viewproduct.patch
Anil, anyone interested,
in the attached patch (viewproduct.patch) I've refactored the script that prepares data for the screen.
It should work as before but without performance issues.
Please test it (also applying filters by product name by qty offset etc... ) and let me know if you find problems.
Before committing it I'd like to hear what do you (Si, David, all) think of the mkt package counting (that is not implemented in this last version).
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip, viewproduct.patch
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=all ]
Anil K Patel updated OFBIZ-379:
-------------------------------
Attachment: FacilityInventoryWithFTL.patch.zip
Patch for displaying Inventory list using FTL.
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12444463 ]
Ashish Vijaywargiya commented on OFBIZ-379:
-------------------------------------------
+1.
Everything is working fine for me too.
Really nice work Jacopo.
Thanks for your precious time.
Regards
Ashish Vijaywargiya
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip, viewproduct.patch
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=all ]
Jacopo Cappellato reassigned OFBIZ-379:
---------------------------------------
Assignee: Jacopo Cappellato
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=all ]
Jacopo Cappellato reopened OFBIZ-379:
-------------------------------------
That's a good point:
what about moving the calls to the service inside the first iteration (that uses the EntityListIterator) and just count (for pagination purposes) only the rows that match the ATP/QOH with the required parameters?
It should be not so difficult to implement, but we will probably need to iterate thru the EntityListIterator one by one instead of using the prodsEli.getPartialList(...) method.
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12444246 ]
Jacopo Cappellato commented on OFBIZ-379:
-----------------------------------------
Anil, Si, David, all,
I thought a lot about this issue this Sunday (while I was driving my car to Florence for the football match :-) because I'd really like to find the best way to fix the screen: in fact it is a central screen for the facility application and it is very common to have in warehouse thousands of products... and so it is very easy to get error messages from the screen... and this could make people think that OFBiz is unstable (and it isn't, isn't it?).
The best thing we can do is probably this:
remove the call to the "getInventoryAvailableByFacility" service and get the total QOH and ATP adding a member entity for "InventoryItem" to the dynamic view in the script, something like this:
prodView.addMemberEntity("IITE", "InventoryItem");
prodView.addViewLink("PRFA", "IITE", Boolean.FALSE, ModelKeyMap.makeKeyMapList("productId", "facilityId"));
prodView.addAlias("IITE", "totalQuantityOnHandTotal", "quantityOnHandTotal", null, null, null, "sum");
prodView.addAlias("IITE", "totalAvailableToPromiseTotal", "availableToPromiseTotal", null, null, null, "sum");
if (hasOffsetQOH) {
//condition: (totalQuantityOnHandTotal - minimumStock) > offsetQOH
// QUESTION: is it possible to add a condition like this?
}
if (hasOffsetATP) {
//condition: (totalAvailableToPromiseTotal - minimumStock) > offsetATP
// QUESTION: is it possible to add a condition like this?
}
I need help here: is it possible to specify a condition based on the difference of two fields (e.g. totalAvailableToPromiseTotal - minimumStock > 10)?
This will solve all the pagination and performace issues, but there are two cons:
a) the virtual inventory for marketing packages will no more be supported in this screen
b) the serialized inventory could be a problem (since it is not guaranteed that the qoh and atp fields are set for serialized items)
In my opinion they are minor issues that could be solved in the following way:
for a) we could keep the original version of the screen and move it in the reports menu of the facility application
for b) : I'm not sure who is using the serialized stuff (there are a few bugs here and there) but it would be nice to always set qoh/atp for serialized inventory too (I remember that Si already proposed something like this some time ago).
What do you think?
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12443022 ]
Jacopo Cappellato commented on OFBIZ-379:
-----------------------------------------
Anil,
I had a quick look at Leon's patch in OFBIZ-364 and it seems to me that the command:
context.put("overrideFormListSize", new Integer(iterator.currentIndex()));
should be enough to make the pagination work: in fact the form will get the "overrideFormListSize" parameter from the context.
If it doesn't work for you: are you sure you have applied correctly the patch attached to the issue and then rebuilt your system?
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=all ]
Jacopo Cappellato closed OFBIZ-379.
-----------------------------------
Resolution: Fixed
I've committed the mods in svn rev. 467444 (see the commit log for details).
The original script (with its pros -support for mkt pkg - and cons - slowness) is still available and used by the almost identical screen under the report menu.
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip, viewproduct.patch
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12442989 ]
Si Chen commented on OFBIZ-379:
-------------------------------
Actually I think the real problem is that it retrieves a list of all the products, then calls the service getAvailableInventory for each product, which then goes and does pretty complicated stuff.
So yes it does take a long time, but it also does a lot of work for you!
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12443007 ]
Si Chen commented on OFBIZ-379:
-------------------------------
Jacopo,
I think that's a good idea.
I have no problems with FTL but I don't think you need to do so much more work. The pagination works for me. What is happening when you try to paginate? Is there an error? Or what happens?
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12443032 ]
Jacopo Cappellato commented on OFBIZ-379:
-----------------------------------------
Anil,
that's great!
If it's not too much work for you, I'd suggest to attach to this issue the two patches; I'd prefer to keep the form widget (and so to apply Leon's patch after reviewing it), but if we find issues with this approach also the ftl thing could be fine.
Jacopo
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12442873 ]
David E. Jones commented on OFBIZ-379:
--------------------------------------
Probably because it is not using the EntityListIterator, but instead doing a findByAnd or something and pulling (or trying to pull...) all results into memory before starting to render the page.
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very
slow, returns error if there are 10,000 products
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12444791 ]
Ashish Vijaywargiya commented on OFBIZ-379:
-------------------------------------------
Hi Jacopo,
Can you please take a look at this issue : http://issues.apache.org/jira/browse/OFBIZ-407
Inventory Item screen is not working and returning Java Heap Memory error.
Regards
Ashish Vijaywargiya
> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip, viewproduct.patch
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira