You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/11/28 19:19:54 UTC

[GitHub] kkhatua commented on issue #1504: DRILL-6792: Find the right probe side fragment wrapper & fix DrillBuf…

kkhatua commented on issue #1504: DRILL-6792: Find the right probe side fragment wrapper & fix DrillBuf…
URL: https://github.com/apache/drill/pull/1504#issuecomment-442570977
 
 
   @weijietong I noticed there are changes between the last unsquashed commit and the latest commit that you force-pushed. I'm assuming nothing changed code-wise, but I see you've introduced a new dependency: `antlr-runtime` and that the Guava imports (Google Common) is not shaded.
   For example, 
   ```
   import com.google.common.collect.Lists;
   import com.google.common.collect.Sets;
   ``
   should be changed to 
   ```
   import org.apache.drill.shaded.guava.com.google.common.collect.Lists;
   import org.apache.drill.shaded.guava.com.google.common.collect.Sets;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services