You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "acogoluegnes (via GitHub)" <gi...@apache.org> on 2026/10/22 14:04:04 UTC
[PR] Notify closing links when their parent endpoint closes [qpid-protonj2]
acogoluegnes opened a new pull request, #26:
URL: https://github.com/apache/qpid-protonj2/pull/26
A link closed or detached locally and waiting for the remote detach was not notified when its parent session or connection was closed. As the remote detach never arrives after the session end, closing the link from the client blocked until the close timeout (60 seconds by default), for example when the remote answers a detach with an end.
The parent endpoint closed handler is now also fired for links that are locally closed or detached but not yet remotely closed or detached.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] Notify closing links when their parent endpoint closes [qpid-protonj2]
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 merged PR #26:
URL: https://github.com/apache/qpid-protonj2/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] Notify closing links when their parent endpoint closes [qpid-protonj2]
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 commented on code in PR #26:
URL: https://github.com/apache/qpid-protonj2/pull/26#discussion_r4350029191
##########
protonj2/src/test/java/org/apache/qpid/protonj2/engine/impl/ProtonSenderTest.java:
##########
@@ -388,6 +388,120 @@ public void testSenderReceivesParentConnectionClosedEvent() throws Exception {
assertNull(failure);
}
+ @Test
Review Comment:
It seems reasonable to add the equivalent tests to the ProtonReceiverTest as you took the time to add receiver tests for the client module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] Notify closing links when their parent endpoint closes [qpid-protonj2]
Posted by "acogoluegnes (via GitHub)" <gi...@apache.org>.
acogoluegnes commented on PR #26:
URL: https://github.com/apache/qpid-protonj2/pull/26#issuecomment-6345894138
Thanks for the follow-up. I added tests, created the JIRA, and updated the commit message accordingly.
You're right that the remote isn't behaving as it should: ideally it would answer the detach, with an error if needed. We found this with our own broker, which ends the session when it fails to process a detach, and we're fixing that on our side.
But it's still valid AMQP, since either peer can end a session at any time, and it can happen in the field. For example, the remote may end the session for some other reason while our detach is in flight. When that happens, the client shouldn't wait the full close timeout for a detach that can never arrive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org