You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/17 13:37:12 UTC
[GitHub] [camel-k] astefanutti opened a new pull request #1624: Traits configuration API and schema
astefanutti opened a new pull request #1624:
URL: https://github.com/apache/camel-k/pull/1624
This PR moves the traits configuration into the API. This enables the generation of the openAPI schema for the traits configuration into the `Integration`, `IntegrationPlatform` and `IntegrationKit` CRDs.
While this simplifies traits management internally, thanks to a strongly-typed API, it currently breaks add-ons. A solution must be found to elegantly marry the benefits of strong typing and extensibility. Besides, the documentation generation must be updated. Last but not least, the intermediate `Configuration` field, previously present in the trait configuration has been removed.
Fixes #1614.
**Release Note**
```release-note
feat(CRD): Traits configuration schema
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1624: Traits configuration API and schema
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1624:
URL: https://github.com/apache/camel-k/pull/1624#issuecomment-660169127
Maybe something like https://book.kubebuilder.io/multiversion-tutorial/conversion.html could help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti edited a comment on pull request #1624: Traits configuration API and schema
Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on pull request #1624:
URL: https://github.com/apache/camel-k/pull/1624#issuecomment-660162445
> I have the impression that the removal of configuration changes the APIs so it should make camel sources not to work because of this: https://github.com/knative/eventing-contrib/blob/24a300fdb0604bd0610091c0bd4d5700ba37a897/camel/source/pkg/reconciler/resources/integration.go#L70-L77
You're right. That's the reason why the Yaks tests fail, as these cover Camel sources. I still fail to see the value of that intermediate field from a pure API standpoint, plus it makes the code a lot simpler. That being it should be possible to maintain it. Otherwise, we can delay that change until version 2.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] nicolaferraro commented on pull request #1624: Traits configuration API and schema
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #1624:
URL: https://github.com/apache/camel-k/pull/1624#issuecomment-660164566
Yeah, maybe we can find a transition mechanism that can allow the api to evolve.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] nicolaferraro edited a comment on pull request #1624: Traits configuration API and schema
Posted by GitBox <gi...@apache.org>.
nicolaferraro edited a comment on pull request #1624:
URL: https://github.com/apache/camel-k/pull/1624#issuecomment-660157846
I have the impression that the removal of configuration changes the APIs so it should make camel sources not to work because of this: https://github.com/knative/eventing-contrib/blob/24a300fdb0604bd0610091c0bd4d5700ba37a897/camel/source/pkg/reconciler/resources/integration.go#L70-L77
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti closed pull request #1624: Traits configuration API and schema
Posted by GitBox <gi...@apache.org>.
astefanutti closed pull request #1624:
URL: https://github.com/apache/camel-k/pull/1624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti edited a comment on pull request #1624: Traits configuration API and schema
Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on pull request #1624:
URL: https://github.com/apache/camel-k/pull/1624#issuecomment-660199016
> I'm not sure about how all this work, but is kube able to manage resources at different versions without doing auto-conversion and screwing everthing up?
Right, that seems too good to be true. That remains to be checked if that delivers on its promises.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1624: Traits configuration API and schema
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1624:
URL: https://github.com/apache/camel-k/pull/1624#issuecomment-660199016
> I'm not sure about how all this work, but is kube able to manage resources at different versions without doing auto-conversion and screwing everthing up?
Right, that seems too good to be true. That remains to be checked if that deliver on its promises.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1624: Traits configuration API and schema
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1624:
URL: https://github.com/apache/camel-k/pull/1624#issuecomment-660162445
> I have the impression that the removal of configuration changes the APIs so it should make camel sources not to work because of this: https://github.com/knative/eventing-contrib/blob/24a300fdb0604bd0610091c0bd4d5700ba37a897/camel/source/pkg/reconciler/resources/integration.go#L70-L77
You're right. That the reason why the Yaks tests fail, as it tests Camel sources. I still fail to see the value of that intermediate field from a pure API standpoint, plus it makes the code a lot simpler. That being it should be possible to maintain it. Otherwise, we can delay that change until version 2.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] nicolaferraro commented on pull request #1624: Traits configuration API and schema
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #1624:
URL: https://github.com/apache/camel-k/pull/1624#issuecomment-660173712
> Maybe something like https://book.kubebuilder.io/multiversion-tutorial/conversion.html could help.
That would be perfect.
I'm not sure about how all this work, but is kube able to manage resources at different versions without doing auto-conversion and screwing everthing up?
I remember some tests I did with @lgarciaaco that ended by giving up every hope.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] nicolaferraro commented on pull request #1624: Traits configuration API and schema
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #1624:
URL: https://github.com/apache/camel-k/pull/1624#issuecomment-660157846
I have the impression that the removal of configuration changes the APIs so, it should make camel sources not to work because of this: https://github.com/knative/eventing-contrib/blob/24a300fdb0604bd0610091c0bd4d5700ba37a897/camel/source/pkg/reconciler/resources/integration.go#L70-L77
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org