You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/24 13:47:04 UTC
[GitHub] [pulsar] eolivelli opened a new pull request, #16212: [improvement][broker]: remove spammy log 'The count of topics on the bundle {} is less than 2, skip split!'
eolivelli opened a new pull request, #16212:
URL: https://github.com/apache/pulsar/pull/16212
### Motivation
The log like "The count of topics on the bundle {} is less than 2, skip split!" is spammy and useless.
### Modifications
Move that line to level "DEBUG"
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on a diff in pull request #16212: [improvement][broker]: remove spammy log 'The count of topics on the bundle {} is less than 2, skip split!'
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #16212:
URL: https://github.com/apache/pulsar/pull/16212#discussion_r906133179
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/BundleSplitterTask.java:
##########
@@ -73,7 +73,9 @@ public Set<String> findBundlesToSplit(final LoadData loadData, final PulsarServi
final String bundle = entry.getKey();
final NamespaceBundleStats stats = entry.getValue();
if (stats.topics < 2) {
- log.info("The count of topics on the bundle {} is less than 2, skip split!", bundle);
+ if (log.isDebugEnabled()) {
Review Comment:
is that ```if (log.isDebugEnabled()) {``` necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #16212: [improvement][broker]: remove spammy log 'The count of topics on the bundle {} is less than 2, skip split!'
Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #16212:
URL: https://github.com/apache/pulsar/pull/16212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a diff in pull request #16212: [improvement][broker]: remove spammy log 'The count of topics on the bundle {} is less than 2, skip split!'
Posted by GitBox <gi...@apache.org>.
eolivelli commented on code in PR #16212:
URL: https://github.com/apache/pulsar/pull/16212#discussion_r906233349
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/BundleSplitterTask.java:
##########
@@ -73,7 +73,9 @@ public Set<String> findBundlesToSplit(final LoadData loadData, final PulsarServi
final String bundle = entry.getKey();
final NamespaceBundleStats stats = entry.getValue();
if (stats.topics < 2) {
- log.info("The count of topics on the bundle {} is less than 2, skip split!", bundle);
+ if (log.isDebugEnabled()) {
Review Comment:
This is the style of our codebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org