[jira] [Commented] (FLINK-4245) Metric naming improvements

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455162#comment-15455162 ] 

ASF GitHub Bot commented on FLINK-4245:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2418
  
    How about this: Let's create the JMX metrics with properly filtered names. Re-creating the Hashtable is what it is.
    
    If we see this becoming an issue, we can actually have a background thread do the initialization of JMX metrics (poll from a registration queue and create the beans).


> Metric naming improvements
> --------------------------
>
>                 Key: FLINK-4245
>                 URL: https://issues.apache.org/jira/browse/FLINK-4245
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>            Reporter: Stephan Ewen
>
> A metric currently has two parts to it:
>   - The name of that particular metric
>   - The "scope" (or namespace), defined by the group that contains the metric.
> A metric group actually always implicitly has a map of naming "tags", like:
>   - taskmanager_host : <some-hostname>
>   - taskmanager_id : <id>
>   - task_name : "map() -> filter()"
> We derive the scope from that map, following the defined scope formats.
> For JMX (and some users that use JMX), it would be natural to expose that map of tags. Some users reconstruct that map by parsing the metric scope. JMX, we can expose a metric like:
>   - domain: "taskmanager.task.operator.io"
>   - name: "numRecordsIn"
>   - tags: { "hostname" -> "localhost", "operator_name" -> "map() at X.java:123", ... }
> For many other reporters, the formatted scope makes a lot of sense, since they think only in terms of (scope, metric-name).
> We may even have the formatted scope in JMX as well (in the domain), if we want to go that route. 
> [~jgrier] and [~Zentol] - what do you think about that?
> [~mdaxini] Does that match your use of the metrics?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)