You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@distributedlog.apache.org by jiazhai <gi...@git.apache.org> on 2017/03/31 00:53:33 UTC
[GitHub] incubator-distributedlog pull request #124: DL-195: exclude DISCLAIMER.bin.t...
GitHub user jiazhai opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/124
DL-195: exclude DISCLAIMER.bin.txt for Apache Rat Check Failures
"mvn apache-rat:check package findbugs:check -DskipTests" would fail with report:
```
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.7:check (default-cli) on project distributedlog_2.10: Too many unapproved licenses: 1 -> [Help 1]
```
Check the rat report, seems we need to exclude file DISCLAIMER.bin.txt from rat checking.
After exclude 1 file for rat check, by adding this line at line232 of pom.xml, we could execute above command successfully,
```
<exclude>src/main/resources/DISCLAIMER.bin.txt</exclude>
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiazhai/incubator-distributedlog DL-195
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/124.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #124
----
commit f2cb5f4b68411e30a8cab4651a403617b1d94670
Author: jiazhai <ji...@users.noreply.github.com>
Date: 2016-11-04T09:33:39Z
Merge pull request #1 from apache/master
update to catch up with main stream
commit a40f92ffefa30e231b60213bba5ffcc1187da766
Author: jiazhai <ji...@users.noreply.github.com>
Date: 2017-01-09T08:22:43Z
Merge pull request #2 from apache/master
update master stream to catch up 1_9
commit f30f454186dfc461328cd78adf870ac0a2b272f6
Author: jiazhai <zh...@gmail.com>
Date: 2017-03-31T00:42:05Z
Merge remote-tracking branch 'us/master'
commit 6c642c3392e5d4e412068366ec006dac214713dc
Author: jiazhai <zh...@gmail.com>
Date: 2017-03-31T00:46:20Z
exclude 1 file to pass rat check
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog pull request #124: DL-195: exclude DISCLAIMER.bin.t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-distributedlog/pull/124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog issue #124: DL-195: exclude DISCLAIMER.bin.txt for ...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/124
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---