You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/08 19:05:48 UTC
[GitHub] [incubator-nuttx] davids5 opened a new pull request, #6814: s32k1 EDMA clean up and loop support
davids5 opened a new pull request, #6814:
URL: https://github.com/apache/incubator-nuttx/pull/6814
## Summary
1. Added DMAMUX for S32k146
2. Fixed missing comment S32K1XX_DMAMUX_CHCFG macro
3. EDMA Fix access violation causing resets and hardfaults due to 32 bit access to 8 bit registers.
4. HW TCD reset of DLASTSGA is 32 Bits.
5. Fixed initialization so the s32k1xx_dmach_getcount reports 0 when Done.
6. TCD has to be 32 byte aligned to work with Scatter Gather
7. ttype was removed - it was used to apply dcache operation on external buffers, but the API does not know the buffer extent, so it is better to do the dcache operations in the code that owns the buffers.
8. Added source or destination looping. Useful for non binary or large sided circular buffers.
9. Added Interrupt on Half or Major loop completion.
10. Scatters gather supports Single interrupt at the end.
11. Order of operations on the HW TCD were corrected.
12. DMA Termination order of operations changed to be able to get meaningful status on DMA completion or Error
13. DMAMUX selection left disabled until used
More driver dependent on this to follow
## Impact
It will compile now and now work.
## Testing
Tested on PX4 nxp_ucans32k146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #6814: s32k1 EDMA clean up and loop support
Posted by GitBox <gi...@apache.org>.
davids5 commented on PR #6814:
URL: https://github.com/apache/incubator-nuttx/pull/6814#issuecomment-1209375676
@pkarashchenko or @xiaoxiang781216 - Please merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6814: s32k1 EDMA clean up and loop support
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6814:
URL: https://github.com/apache/incubator-nuttx/pull/6814#discussion_r940572868
##########
arch/arm/src/s32k1xx/s32k1xx_edma.c:
##########
@@ -623,8 +607,18 @@ static int s32k1xx_edma_interrupt(int irq, void *context, void *arg)
/* Terminate the transfer when it is done. */
- s32k1xx_dmaterminate(dmach, result);
+ if ((dmach->flags & EDMA_CONFIG_LOOP_MASK) == 0)
+ {
+ s32k1xx_dmaterminate(dmach, result);
+ }
+ else if (dmach->callback != NULL)
+ {
+ dmach->callback((DMACH_HANDLE)dmach, dmach->arg,
+ true, result);
+ }
Review Comment:
Please remove few spaces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6814: s32k1 EDMA clean up and loop support
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6814:
URL: https://github.com/apache/incubator-nuttx/pull/6814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #6814: s32k1 EDMA clean up and loop support
Posted by GitBox <gi...@apache.org>.
davids5 commented on PR #6814:
URL: https://github.com/apache/incubator-nuttx/pull/6814#issuecomment-1209261162
@pkarashchenko rebased on master - hopefully the unrelated xtensa CI fail will have been resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org