[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9410: [Refactor] not return too much msg for manual compact action

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #9410:
URL: https://github.com/apache/incubator-doris/pull/9410#discussion_r866704836


##########
be/src/http/action/compaction_action.cpp:
##########
@@ -223,19 +219,32 @@ Status CompactionAction::_execute_compaction_callback(TabletSharedPtr tablet,
         CumulativeCompaction cumulative_compaction(tablet);
         res = cumulative_compaction.compact();
         if (!res) {
-            if (res == Status::OLAPInternalError(OLAP_ERR_BE_NO_SUITABLE_VERSION)) {
-                // Ignore this error code.
-                VLOG_NOTICE << "failed to init cumulative compaction due to no suitable version,"
-                            << "tablet=" << tablet->full_name();
-            } else {
+            if (res != Status::OLAPInternalError(OLAP_ERR_CUMULATIVE_NO_SUITABLE_VERSION)) {

Review Comment:
   Set OLAP_ERR_CUMULATIVE_NO_SUITABLE_VERSION to false in status.h will resolve the problem



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org