You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by Glen Daniels <gd...@macromedia.com> on 2002/12/10 19:39:10 UTC

FW: Unused imports

Axis-dev'ers:

I agree with this being an issue.  Here's my suggestion.

I'll volunteer to do a single commit cleaning up all the imports in the project, using IDEA.  After that we can just be careful about introducing / removing imports appropriately.  IDEA will order the imports as follows:

<all other imports>
<blank line>
javax. and everything under it
java. and everything under it

all alphabetically.

Any objections, +1s, other options?

--Glen

-----Original Message-----
From: Vladimir R. Bossicard [mailto:vladimir@apache.org]
Sent: Tuesday, December 10, 2002 11:17 AM
To: general@xml.apache.org
Subject: Unused imports


Hi all,

I don't know if this was already discussed on this ml (archive not 
available) and if you already read general@jakarta, sorry to reintroduce 
the subject.

Tom Copeland has created a report about the unused imports of the xml 
apache projects <http://cvs.apache.org/~tcopeland/jakarta_bad_imports.htm>.

               #imports  #bad
xml-axis       40,946    532  1.30%
xml-batik      94,300  1,047  1.11%
xml-cocoon      6,384     26  0.41%
xml-cocoon2    43,136    616  1.43%
xml-commons     4,060    120  2.96%
xml-crimson     7,883     46  0.58%
xml-fop        28,210    328  1.16%
xml-rpc         2,921     11  0.38%
xml-security   12,775    361  2.83%
xml-soap        8,844     31  0.35%
xml-stylebook   2,100     52  2.48%
xml-xerces     54,472    406  0.75%
xml-xindice    12,885      8  0.06%

Should be better IMO.

Every IDE (Eclipse, IntelliJ) has an "optimize imports" option so it 
will not take long to fix the imports.  Furthermore it will show that we 
really care about our source code.

-Vladimir

-- 
Vladimir R. Bossicard
Apache Xindice - http://xml.apache.org/xindice


---------------------------------------------------------------------
In case of troubles, e-mail:     webmaster@xml.apache.org
To unsubscribe, e-mail:          general-unsubscribe@xml.apache.org
For additional commands, e-mail: general-help@xml.apache.org

Re: FW: Unused imports

Posted by Davanum Srinivas <di...@yahoo.com>.
+1
--- Glen Daniels <gd...@macromedia.com> wrote:
> 
> Axis-dev'ers:
> 
> I agree with this being an issue.  Here's my suggestion.
> 
> I'll volunteer to do a single commit cleaning up all the imports in the project, using IDEA. 
> After that we can just be careful about introducing / removing imports appropriately.  IDEA will
> order the imports as follows:
> 
> <all other imports>
> <blank line>
> javax. and everything under it
> java. and everything under it
> 
> all alphabetically.
> 
> Any objections, +1s, other options?
> 
> --Glen
> 
> -----Original Message-----
> From: Vladimir R. Bossicard [mailto:vladimir@apache.org]
> Sent: Tuesday, December 10, 2002 11:17 AM
> To: general@xml.apache.org
> Subject: Unused imports
> 
> 
> Hi all,
> 
> I don't know if this was already discussed on this ml (archive not 
> available) and if you already read general@jakarta, sorry to reintroduce 
> the subject.
> 
> Tom Copeland has created a report about the unused imports of the xml 
> apache projects <http://cvs.apache.org/~tcopeland/jakarta_bad_imports.htm>.
> 
>                #imports  #bad
> xml-axis       40,946    532  1.30%
> xml-batik      94,300  1,047  1.11%
> xml-cocoon      6,384     26  0.41%
> xml-cocoon2    43,136    616  1.43%
> xml-commons     4,060    120  2.96%
> xml-crimson     7,883     46  0.58%
> xml-fop        28,210    328  1.16%
> xml-rpc         2,921     11  0.38%
> xml-security   12,775    361  2.83%
> xml-soap        8,844     31  0.35%
> xml-stylebook   2,100     52  2.48%
> xml-xerces     54,472    406  0.75%
> xml-xindice    12,885      8  0.06%
> 
> Should be better IMO.
> 
> Every IDE (Eclipse, IntelliJ) has an "optimize imports" option so it 
> will not take long to fix the imports.  Furthermore it will show that we 
> really care about our source code.
> 
> -Vladimir
> 
> -- 
> Vladimir R. Bossicard
> Apache Xindice - http://xml.apache.org/xindice
> 
> 
> ---------------------------------------------------------------------
> In case of troubles, e-mail:     webmaster@xml.apache.org
> To unsubscribe, e-mail:          general-unsubscribe@xml.apache.org
> For additional commands, e-mail: general-help@xml.apache.org


=====
Davanum Srinivas - http://xml.apache.org/~dims/

__________________________________________________
Do you Yahoo!?
Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
http://mailplus.yahoo.com