You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by mi...@apache.org on 2024/09/13 09:02:54 UTC
(incubator-devlake) branch fix-bugs created (now 1b616be5d)
This is an automated email from the ASF dual-hosted git repository.
mintsweet pushed a change to branch fix-bugs
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
at 1b616be5d fix: some small adjustments
This branch includes the following new commits:
new 1b616be5d fix: some small adjustments
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(incubator-devlake) 01/01: fix: some small adjustments
Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
mintsweet pushed a commit to branch fix-bugs
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
commit 1b616be5dba5d6d9d6b81136fe5eee6286667004
Author: mintsweet <0x...@gmail.com>
AuthorDate: Fri Sep 13 21:02:42 2024 +1200
fix: some small adjustments
---
config-ui/Dockerfile | 1 +
.../blueprint/detail/components/add-connection-dialog/index.tsx | 4 +---
config-ui/src/routes/blueprint/detail/configuration-panel.tsx | 5 ++++-
config-ui/src/routes/project/layout/index.tsx | 4 ++--
4 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/config-ui/Dockerfile b/config-ui/Dockerfile
index c094df4fe..52c197213 100644
--- a/config-ui/Dockerfile
+++ b/config-ui/Dockerfile
@@ -28,6 +28,7 @@ FROM node:18-bookworm-slim as builder
WORKDIR /home/node/code
COPY . .
+RUN cp env.example .env
RUN yarn install
RUN yarn build
diff --git a/config-ui/src/routes/blueprint/detail/components/add-connection-dialog/index.tsx b/config-ui/src/routes/blueprint/detail/components/add-connection-dialog/index.tsx
index ccb2046bf..2846146bf 100644
--- a/config-ui/src/routes/blueprint/detail/components/add-connection-dialog/index.tsx
+++ b/config-ui/src/routes/blueprint/detail/components/add-connection-dialog/index.tsx
@@ -17,7 +17,7 @@
*/
import { useState, useMemo } from 'react';
-import { useNavigate, Link } from 'react-router-dom';
+import { Link } from 'react-router-dom';
import { PlusOutlined } from '@ant-design/icons';
import { Modal, Select, Space, Button } from 'antd';
import styled from 'styled-components';
@@ -62,8 +62,6 @@ export const AddConnectionDialog = ({ disabled = [], onCancel, onSubmit }: Props
const [step, setStep] = useState(1);
const [selectedValue, setSelectedValue] = useState<string>();
- const navigate = useNavigate();
-
const connections = useAppSelector(selectAllConnections);
const options = useMemo(
diff --git a/config-ui/src/routes/blueprint/detail/configuration-panel.tsx b/config-ui/src/routes/blueprint/detail/configuration-panel.tsx
index 0a010226a..479214d14 100644
--- a/config-ui/src/routes/blueprint/detail/configuration-panel.tsx
+++ b/config-ui/src/routes/blueprint/detail/configuration-panel.tsx
@@ -169,7 +169,10 @@ export const ConfigurationPanel = ({ from, blueprint, onRefresh, onChangeTab }:
<NoData
text={
<>
- If you have not created data connections yet, please <Link to="/connections">create connections</Link>{' '}
+ If you have not created data connections yet, please{' '}
+ <Link to="/connections" target="_blank">
+ create connections
+ </Link>{' '}
first and then add them to the project.
</>
}
diff --git a/config-ui/src/routes/project/layout/index.tsx b/config-ui/src/routes/project/layout/index.tsx
index fe504e325..ae0647c22 100644
--- a/config-ui/src/routes/project/layout/index.tsx
+++ b/config-ui/src/routes/project/layout/index.tsx
@@ -122,9 +122,9 @@ export const ProjectLayout = () => {
<Layout>
<Content style={{ padding: '36px 48px', overflowY: 'auto' }}>
<p>
- {breadcrumbs(paths).map((b) => (
+ {breadcrumbs(paths).map((b, i) => (
<span key={b.path}>
- <Link to={b.path}>{b.name}</Link>
+ {i !== paths.length - 2 ? <Link to={b.path}>{b.name}</Link> : <span>{b.name}</span>}
<span> / </span>
</span>
))}