You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Mike Morris (Created) (JIRA)" <ji...@apache.org> on 2012/02/28 14:12:48 UTC
[jira] [Created] (JSPWIKI-722) Build broken under jdk 1.7
Build broken under jdk 1.7
--------------------------
Key: JSPWIKI-722
URL: https://issues.apache.org/jira/browse/JSPWIKI-722
Project: JSPWiki
Issue Type: Bug
Components: Servlet Container/Java compatibility
Affects Versions: 2.8.5
Environment: JDK 1.7
Reporter: Mike Morris
Priority: Minor
Attempting to build under JDK 1.7 causes a compile failure on test class org.apache.wiki.TestJDBCDataSource.
JDK1.7 introduces a new method getParentLogger() in javax.sql.CommonDataSource which is not implemented by TestJDBCDataSource.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JSPWIKI-722) Build broken under jdk 1.7
Posted by "Juan Pablo Santos Rodríguez (Resolved JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juan Pablo Santos Rodríguez resolved JSPWIKI-722.
-------------------------------------------------
Resolution: Fixed
Fix Version/s: 2.9
2.8.5
fixed in 2.9.0-svn-7 and 2.8.5-svn-11
> Build broken under jdk 1.7
> --------------------------
>
> Key: JSPWIKI-722
> URL: https://issues.apache.org/jira/browse/JSPWIKI-722
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.5
> Environment: JDK 1.7
> Reporter: Mike Morris
> Priority: Minor
> Labels: newbie
> Fix For: 2.8.5, 2.9
>
> Attachments: getParentLoggerPatch.diff
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> Attempting to build under JDK 1.7 causes a compile failure on test class org.apache.wiki.TestJDBCDataSource.
> JDK1.7 introduces a new method getParentLogger() in javax.sql.CommonDataSource which is not implemented by TestJDBCDataSource.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JSPWIKI-722) Build broken under jdk 1.7
Posted by "Florian Holeczek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Florian Holeczek updated JSPWIKI-722:
-------------------------------------
Labels: (was: newbie)
Remaining Estimate: (was: 10m)
Original Estimate: (was: 10m)
> Build broken under jdk 1.7
> --------------------------
>
> Key: JSPWIKI-722
> URL: https://issues.apache.org/jira/browse/JSPWIKI-722
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.5
> Environment: JDK 1.7
> Reporter: Mike Morris
> Priority: Minor
> Fix For: 2.8.5, 2.9
>
> Attachments: getParentLoggerPatch.diff
>
>
> Attempting to build under JDK 1.7 causes a compile failure on test class org.apache.wiki.TestJDBCDataSource.
> JDK1.7 introduces a new method getParentLogger() in javax.sql.CommonDataSource which is not implemented by TestJDBCDataSource.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (JSPWIKI-722) Build broken under jdk 1.7
Posted by "Florian Holeczek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Florian Holeczek closed JSPWIKI-722.
------------------------------------
Closing this, since 2.9 has been released
> Build broken under jdk 1.7
> --------------------------
>
> Key: JSPWIKI-722
> URL: https://issues.apache.org/jira/browse/JSPWIKI-722
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.5
> Environment: JDK 1.7
> Reporter: Mike Morris
> Priority: Minor
> Fix For: 2.8.5, 2.9
>
> Attachments: getParentLoggerPatch.diff
>
>
> Attempting to build under JDK 1.7 causes a compile failure on test class org.apache.wiki.TestJDBCDataSource.
> JDK1.7 introduces a new method getParentLogger() in javax.sql.CommonDataSource which is not implemented by TestJDBCDataSource.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JSPWIKI-722) Build broken under jdk 1.7
Posted by "Juan Pablo Santos Rodríguez (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220403#comment-13220403 ]
Juan Pablo Santos Rodríguez commented on JSPWIKI-722:
-----------------------------------------------------
Hello Mike,
unfortunately, we can't apply the attached patch: the build is targetted for Java 1.5 and the patch breaks this:
- first, it uses SQLFeatureNotSupportedException, which is only available under Java 6 and onwards.
- second, it's annotated with @Override, which, under a JDK6 (or downwards) isn't true.
So, to include the patch, getParentLogger should not throw any exception in its signature (also it could possibly return null), and it should not be annotated with @Override
It would be nice to have this in the upcoming RC, so if you attach a new patch we can include it on trunk + 2.8 branch.
> Build broken under jdk 1.7
> --------------------------
>
> Key: JSPWIKI-722
> URL: https://issues.apache.org/jira/browse/JSPWIKI-722
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.5
> Environment: JDK 1.7
> Reporter: Mike Morris
> Priority: Minor
> Labels: newbie
> Attachments: getParentLoggerPatch.diff
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> Attempting to build under JDK 1.7 causes a compile failure on test class org.apache.wiki.TestJDBCDataSource.
> JDK1.7 introduces a new method getParentLogger() in javax.sql.CommonDataSource which is not implemented by TestJDBCDataSource.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JSPWIKI-722) Build broken under jdk 1.7
Posted by "Mike Morris (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Morris updated JSPWIKI-722:
--------------------------------
Attachment: getParentLoggerPatch.diff
Proposed fix for missing getParentLogger under 1.7.
> Build broken under jdk 1.7
> --------------------------
>
> Key: JSPWIKI-722
> URL: https://issues.apache.org/jira/browse/JSPWIKI-722
> Project: JSPWiki
> Issue Type: Bug
> Components: Servlet Container/Java compatibility
> Affects Versions: 2.8.5
> Environment: JDK 1.7
> Reporter: Mike Morris
> Priority: Minor
> Labels: newbie
> Attachments: getParentLoggerPatch.diff
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> Attempting to build under JDK 1.7 causes a compile failure on test class org.apache.wiki.TestJDBCDataSource.
> JDK1.7 introduces a new method getParentLogger() in javax.sql.CommonDataSource which is not implemented by TestJDBCDataSource.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira