You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/11/01 03:39:19 UTC
[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #13187: support XA transaction for proxy #12771
TeslaCN commented on a change in pull request #13187:
URL: https://github.com/apache/shardingsphere/pull/13187#discussion_r739938463
##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/transaction/TransactionBackendHandler.java
##########
@@ -45,6 +47,9 @@
public TransactionBackendHandler(final TCLStatement tclStatement, final TransactionOperationType operationType, final BackendConnection backendConnection) {
this.tclStatement = tclStatement;
this.operationType = operationType;
+ if (tclStatement instanceof MySQLXABeginStatement) {
Review comment:
Could we consider setting the transaction type in configuration rules? Otherwise, the actual transaction type may be inconsistent with the rules.
```
rules:
- !TRANSACTION
defaultType: XA
providerType: Atomikos
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org