You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/04/22 23:21:21 UTC

[GitHub] [bookkeeper] mino181295 opened a new pull request #2319: Issue 2285: Spammy log when one bookie of ensemble is down

mino181295 opened a new pull request #2319:
URL: https://github.com/apache/bookkeeper/pull/2319


   ### Motivation
   
   "Could not connect to bookie" spammed too much times
   
   ### Changes
   
   Debug instead of trace logging level
   
   (Previous issue that added this log #1776)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] eolivelli closed pull request #2319: Issue 2285: Spammy log when one bookie of ensemble is down

Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #2319:
URL: https://github.com/apache/bookkeeper/pull/2319


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2319: Issue 2285: Spammy log when one bookie of ensemble is down

Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #2319:
URL: https://github.com/apache/bookkeeper/pull/2319#discussion_r413522309



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
##########
@@ -2447,12 +2447,16 @@ public void operationComplete(ChannelFuture future) throws Exception {
                     Throwable cause = future.cause();
                     if (cause instanceof UnknownHostException || cause instanceof NativeIoException) {
                         // Don't log stack trace for common errors
-                        LOG.warn("Could not connect to bookie: {}/{}, current state {} : {}",

Review comment:
       If you remove this line how do you know that the client is not able to connect to the bookie?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org