You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2018/03/27 23:40:32 UTC
[Impala-ASF-CR](2.x) Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9833
Change subject: Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.
......................................................................
Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.
This commit should have been marked as don't cherry-pick.
Change-Id: I3295340465284e43852eba0641c1f551d38a0380
---
M bin/ignored_commits.json
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/9833/1
--
To view, visit http://gerrit.cloudera.org:8080/9833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3295340465284e43852eba0641c1f551d38a0380
Gerrit-Change-Number: 9833
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR](2.x) Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9833 )
Change subject: Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I3295340465284e43852eba0641c1f551d38a0380
Gerrit-Change-Number: 9833
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 23:49:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9833 )
Change subject: Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.
......................................................................
Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.
This commit should have been marked as don't cherry-pick.
Change-Id: I3295340465284e43852eba0641c1f551d38a0380
Reviewed-on: http://gerrit.cloudera.org:8080/9833
Tested-by: Philip Zeyliger <ph...@cloudera.com>
Reviewed-by: Michael Brown <mi...@cloudera.com>
---
M bin/ignored_commits.json
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Philip Zeyliger: Verified
Michael Brown: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I3295340465284e43852eba0641c1f551d38a0380
Gerrit-Change-Number: 9833
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR](2.x) Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9833 )
Change subject: Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.
......................................................................
Patch Set 1: Verified+1
There's no point in running GVO on this, because GVO doesn't touch this file, so I'm self-verifying.
I ran "python -mjson.tool bin/ignored_commits.json" to confirm that my JSON is well-formed, and I ran "git show ..." to confirm that the hash I included was a reasonable one.
--
To view, visit http://gerrit.cloudera.org:8080/9833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I3295340465284e43852eba0641c1f551d38a0380
Gerrit-Change-Number: 9833
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 23:41:31 +0000
Gerrit-HasComments: No