You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2018/09/08 21:56:13 UTC
[maven-scm] 01/01: [SCM-908] GitScmProviderRepository#parseUrl():
skip parsing of user info for file:// URLs
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch SCM-908
in repository https://gitbox.apache.org/repos/asf/maven-scm.git
commit 24115a9da9a73c9bbb99c4ebee6fbec389731b23
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Sat Sep 8 23:50:07 2018 +0200
[SCM-908] GitScmProviderRepository#parseUrl(): skip parsing of user info for file:// URLs
---
.../scm/provider/git/repository/GitScmProviderRepository.java | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/repository/GitScmProviderRepository.java b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/repository/GitScmProviderRepository.java
index 0097326..6553c05 100644
--- a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/repository/GitScmProviderRepository.java
+++ b/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/repository/GitScmProviderRepository.java
@@ -372,7 +372,12 @@ public class GitScmProviderRepository
private String parseUserInfo( RepositoryUrl repoUrl, String url )
throws ScmException
{
- // extract user information
+ if ( PROTOCOL_FILE.equals( repoUrl.getProtocol() ) )
+ {
+ // a file:// URL may contain userinfo according to RFC 8089, but our implementation is broken
+ return url;
+ }
+ // extract user information, broken see SCM-907
int indexAt = url.lastIndexOf( '@' );
if ( indexAt >= 0 )
{