You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by bk...@apache.org on 2022/11/30 14:50:47 UTC
[arrow] 03/15: enable JSON converter for StringView/BinaryView
This is an automated email from the ASF dual-hosted git repository.
bkietz pushed a commit to branch feature/format-string-view
in repository https://gitbox.apache.org/repos/asf/arrow.git
commit 84666ed5378ad5312fcb887a38cda66110ea2070
Author: Tobias Zagorni <to...@zagorni.eu>
AuthorDate: Tue Oct 18 17:16:57 2022 +0200
enable JSON converter for StringView/BinaryView
---
cpp/src/arrow/ipc/json_simple.cc | 4 ++++
cpp/src/arrow/json/converter.cc | 2 ++
2 files changed, 6 insertions(+)
diff --git a/cpp/src/arrow/ipc/json_simple.cc b/cpp/src/arrow/ipc/json_simple.cc
index eea0c97302..4d2d803f3f 100644
--- a/cpp/src/arrow/ipc/json_simple.cc
+++ b/cpp/src/arrow/ipc/json_simple.cc
@@ -847,6 +847,8 @@ Status GetDictConverter(const std::shared_ptr<DataType>& type,
PARAM_CONVERTER_CASE(Type::BINARY, StringConverter, BinaryType)
PARAM_CONVERTER_CASE(Type::LARGE_STRING, StringConverter, LargeStringType)
PARAM_CONVERTER_CASE(Type::LARGE_BINARY, StringConverter, LargeBinaryType)
+ PARAM_CONVERTER_CASE(Type::STRING_VIEW, StringConverter, StringViewType)
+ PARAM_CONVERTER_CASE(Type::BINARY_VIEW, StringConverter, BinaryViewType)
SIMPLE_CONVERTER_CASE(Type::FIXED_SIZE_BINARY, FixedSizeBinaryConverter,
FixedSizeBinaryType)
SIMPLE_CONVERTER_CASE(Type::DECIMAL128, Decimal128Converter, Decimal128Type)
@@ -905,6 +907,8 @@ Status GetConverter(const std::shared_ptr<DataType>& type,
SIMPLE_CONVERTER_CASE(Type::BINARY, StringConverter<BinaryType>)
SIMPLE_CONVERTER_CASE(Type::LARGE_STRING, StringConverter<LargeStringType>)
SIMPLE_CONVERTER_CASE(Type::LARGE_BINARY, StringConverter<LargeBinaryType>)
+ SIMPLE_CONVERTER_CASE(Type::STRING_VIEW, StringConverter<StringViewType>)
+ SIMPLE_CONVERTER_CASE(Type::BINARY_VIEW, StringConverter<BinaryViewType>)
SIMPLE_CONVERTER_CASE(Type::FIXED_SIZE_BINARY, FixedSizeBinaryConverter<>)
SIMPLE_CONVERTER_CASE(Type::DECIMAL128, Decimal128Converter<>)
SIMPLE_CONVERTER_CASE(Type::DECIMAL256, Decimal256Converter<>)
diff --git a/cpp/src/arrow/json/converter.cc b/cpp/src/arrow/json/converter.cc
index ec9713e41f..62d8efaf6e 100644
--- a/cpp/src/arrow/json/converter.cc
+++ b/cpp/src/arrow/json/converter.cc
@@ -305,6 +305,8 @@ Status MakeConverter(const std::shared_ptr<DataType>& out_type, MemoryPool* pool
CONVERTER_CASE(Type::STRING, BinaryConverter<StringType>);
CONVERTER_CASE(Type::LARGE_BINARY, BinaryConverter<LargeBinaryType>);
CONVERTER_CASE(Type::LARGE_STRING, BinaryConverter<LargeStringType>);
+ CONVERTER_CASE(Type::BINARY_VIEW, BinaryConverter<BinaryViewType>);
+ CONVERTER_CASE(Type::STRING_VIEW, BinaryConverter<StringViewType>);
CONVERTER_CASE(Type::DECIMAL128, DecimalConverter<Decimal128Type>);
CONVERTER_CASE(Type::DECIMAL256, DecimalConverter<Decimal256Type>);
default: