You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "codeconsole (via GitHub)" <gi...@apache.org> on 2026/08/04 23:46:17 UTC

[PR] Start an embedded MongoDB so generated apps run without one installed [grails-core]

codeconsole opened a new pull request, #16095:
URL: https://github.com/apache/grails-core/pull/16095

   ## Problem
   
   An application generated by Forge with MongoDB selected does not start:
   
   ```
   com.mongodb.MongoSocketOpenException: Exception opening socket
   Caused by: java.net.ConnectException: Connection refused
   ```
   
   Nothing starts a MongoDB, so the application only works if one happens to be listening on the configured url. There is currently no embedded option on `8.0.x` at all — the `embedded-mongodb` feature that existed on `7.0.x` was dropped, and it was test-scoped and pinned to MongoDB 3.2.1 in any case.
   
   ## Approach
   
   A new module, `grails-data-mongodb-embedded`, contributes an `ApplicationContextInitializer` that starts a server and publishes its url into whichever properties the application reads. It is an initializer rather than an auto configuration because the url has to be in the `Environment` before the datastore bean that reads it is created.
   
   Two backends sit behind one interface:
   
   | | `in-memory` (mongo-java-server) | `flapdoodle` |
   |---|---|---|
   | Ships as | `api` dependency of the module | `compileOnly`; applications add it |
   | Start | milliseconds, in-JVM | ~1s, downloads mongod once |
   | Fidelity | no transactions, change streams, `$text` | real mongod |
   | Persistence | none | `database-dir` |
   
   Flapdoodle is deliberately **not** a dependency of the module: it pulls in `org.jgrapht:jgrapht-core`, offered under LGPL-2.1 or EPL-2.0, which an Apache release should not require. An application that wants a real mongod adds it itself, the same way it picks a SQL driver. The published pom contains only `spring-context`, `mongo-java-server` and `slf4j-api`.
   
   The target property is configuration (`embedded.mongodb.property-names`, defaulting to `grails.mongodb.url`) rather than hardcoded, so the module is not limited to Grails Data. Spring Data users remain better served by flapdoodle's own `de.flapdoodle.embed.mongo.spring3x` auto configuration, which this does not duplicate.
   
   ## Forge
   
   `GrailsDataMongoDB` wires this in by default rather than offering it as a separate feature, since the starter not working was the problem. Development and test use the in-memory backend; production uses flapdoodle and keeps its database in `./prodDb`, mirroring how the H2 database is wired for the Grails website application. **No source is generated into the application** — only the dependency and the `environments:` configuration.
   
   ## Verifying
   
   A generated MongoDB application, with no MongoDB installed and no Docker:
   
   ```
   EmbeddedMongoInitializer : Embedded MongoDB started at mongodb://localhost:27017/foo using the in-memory backend
   Application              : Started Application in 1.686 seconds
   Grails application running at http://localhost:8080 in environment: development
   ```
   
   `GET /` returns 200, a driver round-trips a document, and no `mongod` process exists — port 27017 is held by the application JVM.
   
   `EmbeddedMongoInitializerSpec` covers both backends against real servers: a driver round-trip through each, backend selection and its error messages, publishing into several properties, reusing a server that is already listening (the devtools restart path), and the in-memory backend refusing `database-dir` rather than silently discarding data.
   
   ## Notes for review
   
   - **`SbomPlugin`**: mongo-java-server declares only `"The BSD License"`, which CycloneDX maps to BSD-4-Clause. [Its LICENSE](https://github.com/bwaldvogel/mongo-java-server/blob/main/LICENSE) has three numbered clauses and no advertising clause, so it is BSD-3-Clause. Mapped alongside the `org.jline` entries that need the identical correction.
   - **`publish-root-config.gradle`**: a module missing from `publishedProjects` fails configuration with `Extension of type 'GrailsPublishExtension' does not exist`, which does not point at the allowlist.
   - **`compileOnly 'org.apache.groovy:groovy'`** in the module: its main sources are Java so that a plain Spring Boot application can use it, but every published module still produces a groovydoc jar, and groovydoc cannot infer its classpath without Groovy present.
   - The in-memory backend reports `buildInfo.version` as `5.0.0`, so development and test report 5.0 while production under flapdoodle reports 8.0. Worth documenting.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Start and manage an embedded MongoDB so generated apps run without one installed [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16095:
URL: https://github.com/apache/grails-core/pull/16095#issuecomment-5257456548

   ## ✅ All tests passed ✅
   
   🏷️ Commit: 05648caf1a4abca2407272ed0c892acb64681284
   ▶️ Tests:  59295 executed
   ⚪️ Checks: 75/75 completed
   
   ---
   _Learn more about TestLens at [testlens.app](https://testlens.app)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Start and manage an embedded MongoDB so generated apps run without one installed [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16095:
URL: https://github.com/apache/grails-core/pull/16095#issuecomment-5222234942

   ## ✅ All tests passed ✅
   
   🏷️ Commit: 37f771067b06251644cd349c5a4db85e6cc9caef
   ▶️ Tests:  59164 executed
   ⚪️ Checks: 60/60 completed
   
   ---
   _Learn more about TestLens at [testlens.app](https://testlens.app)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Start and manage an embedded MongoDB so generated apps run without one installed [grails-core]

Posted by "sbglasius (via GitHub)" <gi...@apache.org>.
sbglasius commented on code in PR #16095:
URL: https://github.com/apache/grails-core/pull/16095#discussion_r3773436692


##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/database/GrailsDataMongoDB.java:
##########
@@ -34,6 +34,15 @@
 @Singleton
 public class GrailsDataMongoDB extends GormOneOfFeature {
 
+    private static final String DATABASE = "foo";

Review Comment:
   @codeconsole Great change. Thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Start and manage an embedded MongoDB so generated apps run without one installed [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16095:
URL: https://github.com/apache/grails-core/pull/16095#issuecomment-5228920966

   ## ✅ All tests passed ✅
   
   🏷️ Commit: 905964362bed3e1ba215db3b5abe24682a198a3c
   ▶️ Tests:  59192 executed
   ⚪️ Checks: 60/60 completed
   
   ---
   _Learn more about TestLens at [testlens.app](https://testlens.app)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Start and manage an embedded MongoDB so generated apps run without one installed [grails-core]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #16095:
URL: https://github.com/apache/grails-core/pull/16095#issuecomment-5250385003

   <!-- Bito Reply -->
   The naming choice `foo` in the context of the `GrailsDataMongoDB` feature likely refers to a placeholder or a test-related identifier, as `mongo` is already used as the primary namespace for the MongoDB integration. Using `foo` avoids potential naming conflicts or ambiguity with the existing `mongo` package and class structures within the Grails Data MongoDB codebase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Start an embedded MongoDB so generated apps run without one installed [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16095:
URL: https://github.com/apache/grails-core/pull/16095#issuecomment-5187154272

   ## ✅ All tests passed ✅
   
   🏷️ Commit: cfaa324d764c5002a19e1572a16ebe3c984c392d
   ▶️ Tests:  58996 executed
   ⚪️ Checks: 60/60 completed
   
   ---
   _Learn more about TestLens at [testlens.app](https://testlens.app)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Start and manage an embedded MongoDB so generated apps run without one installed [grails-core]

Posted by "sbglasius (via GitHub)" <gi...@apache.org>.
sbglasius commented on code in PR #16095:
URL: https://github.com/apache/grails-core/pull/16095#discussion_r3756085284


##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/database/GrailsDataMongoDB.java:
##########
@@ -34,6 +34,15 @@
 @Singleton
 public class GrailsDataMongoDB extends GormOneOfFeature {
 
+    private static final String DATABASE = "foo";

Review Comment:
   Why `foo` and not `mongo`? Not that it matter much



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Start and manage an embedded MongoDB so generated apps run without one installed [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16095:
URL: https://github.com/apache/grails-core/pull/16095#issuecomment-5248834588

   ## ✅ All tests passed ✅
   
   🏷️ Commit: 9e9c4600bea9e0c9169dace8d9cdd970a162fbd5
   ▶️ Tests:  59105 executed
   ⚪️ Checks: 75/75 completed
   
   ---
   _Learn more about TestLens at [testlens.app](https://testlens.app)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Start and manage an embedded MongoDB so generated apps run without one installed [grails-core]

Posted by "codeconsole (via GitHub)" <gi...@apache.org>.
codeconsole merged PR #16095:
URL: https://github.com/apache/grails-core/pull/16095


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Start an embedded MongoDB so generated apps run without one installed [grails-core]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16095:
URL: https://github.com/apache/grails-core/pull/16095#issuecomment-5186107491

   ## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16095?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `69.71831%` with `43 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 52.3568%. Comparing base ([`4bc5bd8`](https://app.codecov.io/gh/apache/grails-core/commit/4bc5bd82334650c24dee42ce326f1414876f2fb3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`777785a`](https://app.codecov.io/gh/apache/grails-core/commit/777785ac28847c2495a3efd1f38254c21e8afdfb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16095?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...orm/mongodb/embedded/EmbeddedMongoInitializer.java](https://app.codecov.io/gh/apache/grails-core/pull/16095?src=pr&el=tree&filepath=grails-data-mongodb%2Fembedded%2Fsrc%2Fmain%2Fjava%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fmongodb%2Fembedded%2FEmbeddedMongoInitializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGEtbW9uZ29kYi9lbWJlZGRlZC9zcmMvbWFpbi9qYXZhL29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vbW9uZ29kYi9lbWJlZGRlZC9FbWJlZGRlZE1vbmdvSW5pdGlhbGl6ZXIuamF2YQ==) | 72.4138% | [15 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../gorm/mongodb/embedded/FlapdoodleMongoBackend.java](https://app.codecov.io/gh/apache/grails-core/pull/16095?src=pr&el=tree&filepath=grails-data-mongodb%2Fembedded%2Fsrc%2Fmain%2Fjava%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fmongodb%2Fembedded%2FFlapdoodleMongoBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGEtbW9uZ29kYi9lbWJlZGRlZC9zcmMvbWFpbi9qYXZhL29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vbW9uZ29kYi9lbWJlZGRlZC9GbGFwZG9vZGxlTW9uZ29CYWNrZW5kLmphdmE=) | 48.2759% | [13 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...e/gorm/mongodb/embedded/EmbeddedMongoSettings.java](https://app.codecov.io/gh/apache/grails-core/pull/16095?src=pr&el=tree&filepath=grails-data-mongodb%2Fembedded%2Fsrc%2Fmain%2Fjava%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fmongodb%2Fembedded%2FEmbeddedMongoSettings.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGEtbW9uZ29kYi9lbWJlZGRlZC9zcmMvbWFpbi9qYXZhL29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vbW9uZ29kYi9lbWJlZGRlZC9FbWJlZGRlZE1vbmdvU2V0dGluZ3MuamF2YQ==) | 77.7778% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...re/gorm/mongodb/embedded/InMemoryMongoBackend.java](https://app.codecov.io/gh/apache/grails-core/pull/16095?src=pr&el=tree&filepath=grails-data-mongodb%2Fembedded%2Fsrc%2Fmain%2Fjava%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fmongodb%2Fembedded%2FInMemoryMongoBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGEtbW9uZ29kYi9lbWJlZGRlZC9zcmMvbWFpbi9qYXZhL29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vbW9uZ29kYi9lbWJlZGRlZC9Jbk1lbW9yeU1vbmdvQmFja2VuZC5qYXZh) | 88.2353% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/grails-core/pull/16095/graphs/tree.svg?width=650&height=150&src=pr&token=qJrryhpk7u&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/grails-core/pull/16095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##                8.0.x     #16095        +/-   ##
   ==================================================
   + Coverage     52.3426%   52.3568%   +0.0142%     
   - Complexity      18293      18325        +32     
   ==================================================
     Files            2036       2040         +4     
     Lines           96346      96488       +142     
     Branches        16831      16852        +21     
   ==================================================
   + Hits            50430      50518        +88     
   - Misses          38492      38537        +45     
   - Partials         7424       7433         +9     
   ```
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16095?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...e/gorm/mongodb/embedded/EmbeddedMongoSettings.java](https://app.codecov.io/gh/apache/grails-core/pull/16095?src=pr&el=tree&filepath=grails-data-mongodb%2Fembedded%2Fsrc%2Fmain%2Fjava%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fmongodb%2Fembedded%2FEmbeddedMongoSettings.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGEtbW9uZ29kYi9lbWJlZGRlZC9zcmMvbWFpbi9qYXZhL29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vbW9uZ29kYi9lbWJlZGRlZC9FbWJlZGRlZE1vbmdvU2V0dGluZ3MuamF2YQ==) | `77.7778% <77.7778%> (ø)` | |
   | [...re/gorm/mongodb/embedded/InMemoryMongoBackend.java](https://app.codecov.io/gh/apache/grails-core/pull/16095?src=pr&el=tree&filepath=grails-data-mongodb%2Fembedded%2Fsrc%2Fmain%2Fjava%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fmongodb%2Fembedded%2FInMemoryMongoBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGEtbW9uZ29kYi9lbWJlZGRlZC9zcmMvbWFpbi9qYXZhL29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vbW9uZ29kYi9lbWJlZGRlZC9Jbk1lbW9yeU1vbmdvQmFja2VuZC5qYXZh) | `88.2353% <88.2353%> (ø)` | |
   | [.../gorm/mongodb/embedded/FlapdoodleMongoBackend.java](https://app.codecov.io/gh/apache/grails-core/pull/16095?src=pr&el=tree&filepath=grails-data-mongodb%2Fembedded%2Fsrc%2Fmain%2Fjava%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fmongodb%2Fembedded%2FFlapdoodleMongoBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGEtbW9uZ29kYi9lbWJlZGRlZC9zcmMvbWFpbi9qYXZhL29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vbW9uZ29kYi9lbWJlZGRlZC9GbGFwZG9vZGxlTW9uZ29CYWNrZW5kLmphdmE=) | `48.2759% <48.2759%> (ø)` | |
   | [...orm/mongodb/embedded/EmbeddedMongoInitializer.java](https://app.codecov.io/gh/apache/grails-core/pull/16095?src=pr&el=tree&filepath=grails-data-mongodb%2Fembedded%2Fsrc%2Fmain%2Fjava%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fmongodb%2Fembedded%2FEmbeddedMongoInitializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGEtbW9uZ29kYi9lbWJlZGRlZC9zcmMvbWFpbi9qYXZhL29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vbW9uZ29kYi9lbWJlZGRlZC9FbWJlZGRlZE1vbmdvSW5pdGlhbGl6ZXIuamF2YQ==) | `72.4138% <72.4138%> (ø)` | |
   
   ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16095/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Start and manage an embedded MongoDB so generated apps run without one installed [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16095:
URL: https://github.com/apache/grails-core/pull/16095#issuecomment-5224068973

   ## ✅ All tests passed ✅
   
   🏷️ Commit: 8b8bea09af1a0e70545aae4cc4a7a3314ae26547
   ▶️ Tests:  55453 executed
   ⚪️ Checks: 60/60 completed
   
   ---
   _Learn more about TestLens at [testlens.app](https://testlens.app)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Start and manage an embedded MongoDB so generated apps run without one installed [grails-core]

Posted by "codeconsole (via GitHub)" <gi...@apache.org>.
codeconsole commented on code in PR #16095:
URL: https://github.com/apache/grails-core/pull/16095#discussion_r3759831209


##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/database/GrailsDataMongoDB.java:
##########
@@ -34,6 +34,15 @@
 @Singleton
 public class GrailsDataMongoDB extends GormOneOfFeature {
 
+    private static final String DATABASE = "foo";

Review Comment:
   @sbglasius I didn't come up with the naming.  This whole PR was based off the forge cli mongo feature which Puneet wrote in 2022.  He came up with the name foo, probably just as a placeholder because the feature failed if you didn't have a mongo running anyhow. 
   
   Anyhow, good observation.  I renamed it to be in line with the h2/sql side of things in 
   05648ca



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org