You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by li...@apache.org on 2022/05/23 03:44:02 UTC

[rocketmq-apis] branch v2 updated: Allow partial batch-send-failure in protocol perspsective

This is an automated email from the ASF dual-hosted git repository.

lizhanhui pushed a commit to branch v2
in repository https://gitbox.apache.org/repos/asf/rocketmq-apis.git


The following commit(s) were added to refs/heads/v2 by this push:
     new 0899d0e  Allow partial batch-send-failure in protocol perspsective
0899d0e is described below

commit 0899d0e7d4bf235ff07d300d6c9c06371411480e
Author: Li Zhanhui <li...@gmail.com>
AuthorDate: Mon May 23 11:43:52 2022 +0800

    Allow partial batch-send-failure in protocol perspsective
---
 apache/rocketmq/v2/definition.proto |  6 ------
 apache/rocketmq/v2/service.proto    | 12 +++++++++++-
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/apache/rocketmq/v2/definition.proto b/apache/rocketmq/v2/definition.proto
index f8ea444..3153638 100644
--- a/apache/rocketmq/v2/definition.proto
+++ b/apache/rocketmq/v2/definition.proto
@@ -290,12 +290,6 @@ message Message {
 
 message Assignment { MessageQueue message_queue = 1; }
 
-message SendReceipt {
-  string message_id = 1;
-  string transaction_id = 2;
-  int64 offset = 3;
-}
-
 enum Code {
   // Success.
   OK = 0;
diff --git a/apache/rocketmq/v2/service.proto b/apache/rocketmq/v2/service.proto
index 0486047..35cf3a1 100644
--- a/apache/rocketmq/v2/service.proto
+++ b/apache/rocketmq/v2/service.proto
@@ -60,9 +60,19 @@ message SendMessageRequest {
   repeated Message messages = 1;
 }
 
+message SendResultEntry {
+  Status status = 1;
+  string message_id = 2;
+  string transaction_id = 3;
+  int64 offset = 4;
+}
+
 message SendMessageResponse {
   Status status = 1;
-  repeated SendReceipt receipts = 2;
+
+  // Some implementation may have partial failure issues. Client SDK developers are expected to inspect
+  // each entry for best certainty.
+  repeated SendResultEntry entries = 2;
 }
 
 message QueryAssignmentRequest {