You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by st...@duboce.net on 2010/06/11 06:32:57 UTC
Review Request: hbase-2208, a simple fix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/165/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Patch that changes interface for batch put and delete so passes List instead of an array.
Straight-forward change but for some generics wrestling and some gratuitous eclipse reformatting of imports.
This addresses bug hbase-2208.
http://issues.apache.org/jira/browse/hbase-2208
Diffs
-----
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java ed18092
src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java b36f1df
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java a1baff4
Diff: http://review.hbase.org/r/165/diff
Testing
-------
Tests pass but testzookeeper (something broke this).
Thanks,
stack
Re: Review Request: hbase-2208, a simple fix
Posted by st...@duboce.net.
> On 2010-06-10 21:50:16, Todd Lipcon wrote:
> > strange, I could have sworn that IPC didn't work with List<> types. But if tests pass, guess it's OK. Do we have a benchmark that shows it's beneficial?
No benchmark. Seems plain that saving a copy that could be large could only be beneficial?
- stack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/165/#review179
-----------------------------------------------------------
On 2010-06-10 21:32:57, stack wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/165/
> -----------------------------------------------------------
>
> (Updated 2010-06-10 21:32:57)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> Patch that changes interface for batch put and delete so passes List instead of an array.
>
> Straight-forward change but for some generics wrestling and some gratuitous eclipse reformatting of imports.
>
>
> This addresses bug hbase-2208.
> http://issues.apache.org/jira/browse/hbase-2208
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java ed18092
> src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java b36f1df
> src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java a1baff4
>
> Diff: http://review.hbase.org/r/165/diff
>
>
> Testing
> -------
>
> Tests pass but testzookeeper (something broke this).
>
>
> Thanks,
>
> stack
>
>
Re: Review Request: hbase-2208, a simple fix
Posted by Todd Lipcon <to...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/165/#review179
-----------------------------------------------------------
strange, I could have sworn that IPC didn't work with List<> types. But if tests pass, guess it's OK. Do we have a benchmark that shows it's beneficial?
- Todd
On 2010-06-10 21:32:57, stack wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/165/
> -----------------------------------------------------------
>
> (Updated 2010-06-10 21:32:57)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> Patch that changes interface for batch put and delete so passes List instead of an array.
>
> Straight-forward change but for some generics wrestling and some gratuitous eclipse reformatting of imports.
>
>
> This addresses bug hbase-2208.
> http://issues.apache.org/jira/browse/hbase-2208
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java ed18092
> src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java b36f1df
> src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java a1baff4
>
> Diff: http://review.hbase.org/r/165/diff
>
>
> Testing
> -------
>
> Tests pass but testzookeeper (something broke this).
>
>
> Thanks,
>
> stack
>
>
Re: Review Request: hbase-2208, a simple fix
Posted by Todd Lipcon <to...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/165/#review187
-----------------------------------------------------------
Ship it!
+1, lgtm. I didn't realize that HBase's hacked version of IPC does indeed support Lists in trunk. And your point about avoiding a shallow copy makes good sense.
- Todd
On 2010-06-10 21:32:57, stack wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/165/
> -----------------------------------------------------------
>
> (Updated 2010-06-10 21:32:57)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> Patch that changes interface for batch put and delete so passes List instead of an array.
>
> Straight-forward change but for some generics wrestling and some gratuitous eclipse reformatting of imports.
>
>
> This addresses bug hbase-2208.
> http://issues.apache.org/jira/browse/hbase-2208
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java ed18092
> src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java b36f1df
> src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java a1baff4
>
> Diff: http://review.hbase.org/r/165/diff
>
>
> Testing
> -------
>
> Tests pass but testzookeeper (something broke this).
>
>
> Thanks,
>
> stack
>
>