Re: Review Request 63775: SENTRY-1543 dropOrRenamePrivilegeForAllRoles() has confusing code

[Steve Moist via Review Board <no...@reviews.apache.org>]

> On Nov. 15, 2017, 7:11 p.m., Sergio Pena wrote:
> > The subject of the review board must match the JIRA subject. You could either change the JIRA or the Review subject to match the correct fix.
> > 
> > The getUniqueMSentryPrivilege() is still confusing. Any idea of the difference in both methods? Seems getMSentryPrivileges() lacks of the grant option and unique query. The unique query is used to avoid datanucleus to return a list, so this is ok, but how does the grant option being the only difference between a list and a single privilege?
> 
> Steve Moist wrote:
>     My understanding is that getMSentryPrivileges is mainly used to get all the associated roles for a privelege.  I'll take a deeper look into how grant affects it.

Suppose theres a database(db1) with 2 tables(tbl1, tbl2) that have columns. When a user renames a column(db1.tbl1.col1) in Hive the privileges for db1.tbl1.col1 need to be updated, the query to do so needs to be pretty specific to find the right column.  So if they were to simply search for  col1, it would affect also db1.tbl2.col1.  So it needs to query for db, table, and column.  With that said, it also needs to be able to rename all of the columns with different actions, grants, etc.  In the case of a database rename, it needs to get all where db1 = oldname.  So it needs to be as precise and wide as it can be for this to happen.


- Steve


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63775/#review191083
-----------------------------------------------------------


On Nov. 15, 2017, 9:47 p.m., Steve Moist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63775/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2017, 9:47 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: SENTRY-1543
>     https://issues.apache.org/jira/browse/SENTRY-1543
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Renamed methods to be more clear in their use since they both have the same name but function and query differently.
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7217dea7 
> 
> 
> Diff: https://reviews.apache.org/r/63775/diff/1/
> 
> 
> Testing
> -------
> 
> Unit tests ran.
> 
> 
> Thanks,
> 
> Steve Moist
> 
>