You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/02 04:10:46 UTC

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #575: Avoid parsing nil msg.Value

cckellogg commented on a change in pull request #575:
URL: https://github.com/apache/pulsar-client-go/pull/575#discussion_r680641173



##########
File path: pulsar/producer_partition.go
##########
@@ -353,7 +353,7 @@ func (p *partitionProducer) internalSend(request *sendRequest) {
 	payload := msg.Payload
 	var schemaPayload []byte
 	var err error
-	if p.options.Schema != nil {
+	if p.options.Schema != nil && msg.Value != nil {

Review comment:
       If the intention is to bypass the schema encoding/decoding why set the schema on the producer and or topic?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org