[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #486: Migrate multi node testkit to Netty 4.

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #486:
URL: https://github.com/apache/incubator-pekko/pull/486#discussion_r1280662235


##########
project/SbtMultiJvm.scala:
##########
@@ -167,10 +167,11 @@ object MultiJvmPlugin extends AutoPlugin {
       // the first class wins just like a classpath
       // just concatenate conflicting text files
       assembly / assemblyMergeStrategy := {
-        case n if n.endsWith(".class") => MergeStrategy.first
-        case n if n.endsWith(".txt")   => MergeStrategy.concat
-        case n if n.endsWith("NOTICE") => MergeStrategy.concat
-        case n                         => (assembly / assemblyMergeStrategy).value.apply(n)
+        case n if n.endsWith(".class")  => MergeStrategy.first
+        case n if n.endsWith(".txt")    => MergeStrategy.concat
+        case n if n.endsWith("NOTICE")  => MergeStrategy.concat
+        case n if n.endsWith("LICENSE") => MergeStrategy.concat

Review Comment:
   I am wondering why this is an issue with this PR specifically and not with Pekko in general?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org