You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by ch...@apache.org on 2015/02/17 20:14:38 UTC
svn commit: r1660467 -
/uima/sandbox/uima-ducc/trunk/uima-ducc-sm/src/main/java/org/apache/uima/ducc/sm/PingDriver.java
Author: challngr
Date: Tue Feb 17 19:14:37 2015
New Revision: 1660467
URL: http://svn.apache.org/r1660467
Log:
UIMA-4252 Don't allow number of additions to go < 0 in ping driver.
Modified:
uima/sandbox/uima-ducc/trunk/uima-ducc-sm/src/main/java/org/apache/uima/ducc/sm/PingDriver.java
Modified: uima/sandbox/uima-ducc/trunk/uima-ducc-sm/src/main/java/org/apache/uima/ducc/sm/PingDriver.java
URL: http://svn.apache.org/viewvc/uima/sandbox/uima-ducc/trunk/uima-ducc-sm/src/main/java/org/apache/uima/ducc/sm/PingDriver.java?rev=1660467&r1=1660466&r2=1660467&view=diff
==============================================================================
--- uima/sandbox/uima-ducc/trunk/uima-ducc-sm/src/main/java/org/apache/uima/ducc/sm/PingDriver.java (original)
+++ uima/sandbox/uima-ducc/trunk/uima-ducc-sm/src/main/java/org/apache/uima/ducc/sm/PingDriver.java Tue Feb 17 19:14:37 2015
@@ -356,7 +356,7 @@ class PingDriver
int additions = response.getAdditions();
int instances = sset.countImplementors();
if ( additions + instances > max_instances ) {
- additions = max_instances - instances;
+ additions = Math.max(0, max_instances - instances);
logger.warn(methodName, sset.getId(), "Maximum services instances capped by installation limit of", max_instances, "at", additions);
}
@@ -374,7 +374,7 @@ class PingDriver
int refs = sset.countReferences();
int impls = sset.countImplementors();
if ( (impls <= ndeletions) && (refs > 0) ) {
- ndeletions = impls - 1;
+ ndeletions = Math.max(0, impls - 1);
logger.warn(methodName, sset.getId(), "Service shrink value capped at", ndeletions, "because there are still", refs, "references.");
}
}